-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix model analysis weekly pipeline failures #975
Fix model analysis weekly pipeline failures #975
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Once this one is merged, let's kick one more run right away to complete over the weekends :))
Few minor details I spot:
- PCC issues for E2E run are treated as FFE errors. I think in most of the cases right now this is a consequence of TTNN. So let's move it into that group. Once we fix our Golden checks, we can have a customer error separating the two.
- When we have unknown errors, let's subtract that percentage from all 3 component passing score results. This is mostly to emphasize that when passing rate is 99%, that it's not actually that close if we have 20% in N/A field. However, this isn't a blocker for this PR.
FYI, there is weekly scheduled on serbia time: saturday at 12:00 AM |
If that si the case, than there is no need to run one manually. Let's wait for regular one to run over the weekend :)) |
6232917
to
2d36123
Compare
Moved the pcc issues exception rule from Forge Compiler Component to TT-Metal Compiler Component.
The unknown compiler component percentage is subtracted from the other compiler components pass percentage. |
2d36123
to
24882fc
Compare
24882fc
to
a42139e
Compare
The PR will fix below issues found in the Model Analysis Weekly pipeline - Link