Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding GitHub Pipeline for TT-Forge #54

Merged
merged 14 commits into from
Aug 14, 2024
Merged

Adding GitHub Pipeline for TT-Forge #54

merged 14 commits into from
Aug 14, 2024

Conversation

vmilosevic
Copy link
Collaborator

@vmilosevic vmilosevic commented Aug 12, 2024

Adding GitHub Pipeline for TT-Forge

The main workflow runs using a Docker container and can execute tests on silicon. The Docker image has a prebuilt toolchain and all necessary dependencies.
Note: The Docker image is too large to be built on the GitHub runner; it must be built locally or on a self-hosted runner.

Changes Made:

  • Added Dockerfile and workflow for building the image
  • Added GitHub workflow for building and testing
  • Modified CMake: moved MLIR environment build to toolchain build
  • Updated pytest.ini: selected only valid tests
  • Removed GitLab CI
  • Removed previous GitHub pipeline

Closes: #56

@vmilosevic vmilosevic changed the title [Draft] Build docker image Adding GitHub Pipeline for TT-Forge Aug 14, 2024
@vmilosevic vmilosevic marked this pull request as ready for review August 14, 2024 12:36
if: success() || failure()
with:
report_paths: reports/report.xml
check_name: MLIR Tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TT-Forge Tests or TT-Forge E2E Tests...

TTMLIR_TOOLCHAIN_DIR=${TTMLIR_TOOLCHAIN_DIR} # Export TTMLIR_TOOLCHAIN_DIR to use
TTMLIR_VENV_DIR=${TTMLIR_VENV_DIR} # Export TTMLIR_VENV_DIR to use
bash ${CMAKE_CURRENT_SOURCE_DIR}/../third_party/build_mlir_env.sh
WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/../third_party/tt-mlir
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a TT_MLIR_ROOT_DIR in pybuda/csrc/CMakeLists.txt, maybe we can move that var into main cmake file, and use it here. Also we can move build_mlir_env.sh to the env/ so we don't have to search for it here...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I tried a few variants but they didn't seem any better. I think this is ok for now

@vmilosevic vmilosevic merged commit 0b5aa21 into main Aug 14, 2024
2 checks passed
@vmilosevic vmilosevic deleted the vmilosevic/github_ci branch August 14, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Setup CI job for doc build (release, manual trigger)
3 participants