Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix forge types missing formatter #206

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

mtopalovicTT
Copy link
Contributor

@mtopalovicTT mtopalovicTT commented Aug 31, 2024

Adding formatter for forge types to enable debug build without any hacks.
I tried several different approaches to "catch all" types with single templated struct but it seems that everyone is doing it this way (torch/scylladb)

Copy link
Contributor

@nvukobratTT nvukobratTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Adding formatter for forge types to enable debug build without any
hacks.
@mtopalovicTT mtopalovicTT force-pushed the milant/fixing_fmt_dbg_printing branch from 8ec4a13 to 67d7853 Compare September 2, 2024 14:16
@mtopalovicTT mtopalovicTT merged commit 6c5cbb0 into main Sep 2, 2024
1 of 2 checks passed
@pilkicTT pilkicTT deleted the milant/fixing_fmt_dbg_printing branch September 5, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants