Fix: Correct torchvision installation order in tt-buda-demos #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milank94
added
bug
milank94
approved these changes
Dec 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the installation issue I created now, here is my suggested fix.
This pull request addresses an installation error encountered when installing
pybudaon Linux systems, caused by an incorrect installation order of the required wheel files.Problem:
The previous installation instructions in
1_install_tt_buda.mdspecified the following order for installing wheel files:pip install pybuda-.whl tvm-.whl torchvision-.whl
This order led to the following error on Linux (specifically tested on a Linux environment that installs pybuda for the first time):
ERROR: Could not find a version that satisfies the requirement torchvision==0.16.0+fbb4cc5 (from pybuda) (from versions: 0.1.6, 0.1.7, ..., 0.20.1)
ERROR: No matching distribution found for torchvision==0.16.0+fbb4cc5
This error occurs because pybuda depends on a specific version of torchvision provided by Tenstorrent. Installing pybuda before the Tenstorrent-provided torchvision wheel resulted in pip attempting to resolve the dependency from the standard PyPI repository, which does not contain the required version.
Solution:
This pull request corrects the installation order in 1_install_tt_buda.md to:
pip install torchvision-.whl pybuda-.whl tvm-.whl
Installing the Tenstorrent-provided torchvision wheel first ensures that the correct version is available when pybuda is installed, satisfying its dependency.
Testing:
After applying this change, the installation was successfully tested on a Linux environment. The installation now completes without errors.
Changes:
Modified tt-buda-demos/first_5_steps/1_install_tt_buda.md:
Changed the pip install command order from
pybuda-.whl tvm-.whl torchvision-.whl
to
torchvision-.whl pybuda-.whl tvm-.whl.
This simple change resolves the installation issue and ensures a smooth installation experience for all users.