Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notice regarding custom gradient support in Windows #487

Merged
merged 2 commits into from
Feb 17, 2023

Conversation

karllessard
Copy link
Collaborator

Custom gradient registration in Windows is broken since we've upgraded to TF 2.10.1. Since this is not a strongly used feature, we'll keep it like that and simply adding a notice for users who might face this problem.

See #486

Craigacp
Craigacp previously approved these changes Feb 16, 2023
Copy link
Collaborator

@Craigacp Craigacp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Craigacp
Copy link
Collaborator

Is it worth adding an explicit windows check so we can throw UnsupportedOperationException rather than have the JVM go down?

Copy link
Collaborator

@Craigacp Craigacp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karllessard karllessard merged commit a447b4b into tensorflow:master Feb 17, 2023
@karllessard karllessard deleted the windows-support-notice branch February 17, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants