Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Fingerprint class and add experimental namespace. #439

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Introduce Fingerprint class and add experimental namespace. #439

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fd9b48b
add experimental
monicadsong Jan 11, 2023
8bf4bb8
experimental
monicadsong Jan 11, 2023
692c0e6
accidentally changed status
monicadsong Jan 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions rfcs/20220610-saved-model-fingerprinting.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
# SavedModel Fingerprinting

| Status | Accepted |
| Status | Accepted |
:-------------- |:---------------------------------------------------- |
| **RFC #** | 415 |
| **Author(s)** | Monica Song ([email protected]) |
| **Sponsor** | Cesar Crusius ([email protected]) |
| **Updated** | 2022-06-10 |
| **Updated** | 2023-01-11 |

## Objective

Expand Down Expand Up @@ -184,7 +184,10 @@ One drawback of having a separate file is that it is a potentially significant c

All fingerprints will be written to disk automatically, and there is no way to bypass or customize writing fingerprints when serializing a SavedModel.

There will be a public API in python `tf.saved_model.read_fingerprint(export_dir)` which returns a dictionary mapping the names of the fields in the protobuf (i.e. "saved_model_checksum", "graph_def_program_hash", "signature_def_hash", "saved_object_graph_hash", "checkpoint_hash", "version") to their values.
There will be an API in python `tf.saved_model.read_fingerprint(export_dir)` which returns a `Fingerprint` object
(`tf.saved_model.Fingerprint`) containing the values of the fingerprint.

Following convention, these two new public APIs will be released under the "experimental" namespace, i.e. `tf.saved_model.experimental` and then graduate to non-experimental when stable.

### Validation

Expand Down