Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build with TF 2.14 #2856

Merged
merged 4 commits into from
Nov 20, 2023
Merged

Build with TF 2.14 #2856

merged 4 commits into from
Nov 20, 2023

Conversation

georgiyekkert
Copy link
Contributor

Description

Create a patch to use non_hermetic python in TF, bump workspace TF version to 2.14.0

@boring-cyborg boring-cyborg bot added the build label Nov 9, 2023
@georgiyekkert
Copy link
Contributor Author

@bhack PTAL

@bhack bhack requested a review from seanpmorgan November 10, 2023 11:33
@bhack
Copy link
Contributor

bhack commented Nov 10, 2023

@georgiyekkert Thanks.
@seanpmorgan Probably it is better to review and merge this before starting the 2.15 PR.

@@ -0,0 +1,74 @@
diff --git tensorflow/tools/toolchains/cpus/aarch64/aarch64_compiler_configure.bzl tensorflow/tools/toolchains/cpus/aarch64/aarch64_compiler_configure.bzl
Copy link
Contributor

@bhack bhack Nov 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seanpmorgan NIP: There could be the risk that this will be invalidated on 2.15 and we need to manually regenerate that patch on new releases.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but it appears that other repos (e.g. tf/federated) depend on this too so I'm okay with trying this strategy for the couple of releases we have left

@bhack bhack linked an issue Nov 10, 2023 that may be closed by this pull request
Copy link
Member

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@seanpmorgan seanpmorgan merged commit 48f1125 into tensorflow:master Nov 20, 2023
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot build tensorflow addons with TF 2.14
3 participants