suppress gcc error on arch, block device compatible ( /dev/xxx) and let sdl gui works in pure wayland #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t sdl in pure wayland mode
This was referenced Oct 29, 2024
nooodles2023
reviewed
Nov 2, 2024
| if(ioctl(fd_,BLKGETSIZE64,&size_blockdevice)!=-1) { | ||
| total_blocks_ = size_blockdevice / block_size_; | ||
| block_size_ = 512; | ||
| total_blocks_ = size_blockdevice / block_size_; |
|
oh yes sorry
I pull again
Le sam. 2 nov. 2024 à 12:00, Andy ***@***.***> a écrit :
… ***@***.**** commented on this pull request.
------------------------------
In images/raw.cc
<#64 (comment)>:
> fd_ = open(filepath_.c_str(), oflags);
if (fd_ < 0)
MV_PANIC("disk file not found: %s", filepath_.c_str());
-
- struct stat st;
- fstat(fd_, &st);
- block_size_ = 512;
- total_blocks_ = st.st_size / block_size_;
+ long long size_blockdevice;
+ if(ioctl(fd_,BLKGETSIZE64,&size_blockdevice)!=-1) {
+ total_blocks_ = size_blockdevice / block_size_;
+ block_size_ = 512;
+ total_blocks_ = size_blockdevice / block_size_;
duplicated code？
—
Reply to this email directly, view it on GitHub
<#64 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMCNUBABRKUFDEIHVYDGILZ6SWDPAVCNFSM6AAAAABQZJ3YRCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIMJRGIZTGMBTGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.