Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Laravel 11. #1047

Open
wants to merge 2 commits into
base: 5.x
Choose a base branch
from
Open

Upgrade to Laravel 11. #1047

wants to merge 2 commits into from

Conversation

mikebronner
Copy link
Contributor

No description provided.

@ArlonAntonius
Copy link
Member

@mikebronner Thank you for starting the effort on this, let us know if there's anything we can do to help update this package.

@chintan13
Copy link

Looking for upgrade to laravel 11, thank you!

@mikebronner mikebronner marked this pull request as ready for review December 4, 2024 13:54
@mikebronner
Copy link
Contributor Author

mikebronner commented Dec 4, 2024

After testing this for several months now on my clients I have not encountered any issues. @ArlonAntonius marking this ready for review. Although I have not used the two file methods. Could use some help implementing those.

@ArlonAntonius
Copy link
Member

@mikebronner have you really been tesing it in production like this?
So simply CI is broken?

@mikebronner
Copy link
Contributor Author

mikebronner commented Dec 4, 2024

@ArlonAntonius Yes, correct, but with the caveat that we have not been using file uploads in our multi-tenant apps. I assume the CI issues are from Laravel 11 now requiring PHP 8.2+, but I am unable to see why the CI is failing (when I click on the link it asks me to log in).

Comment on lines +105 to +113
public function putFile($path, $file = null, $options = [])
{
// tba
}

public function putFileAs($path, $file, $name = null, $options = [])
{
// tba
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikebronner Maybe the only thing that still needs to be added are these methods to make sure nobody's application actually fails. Other than that: I'm fine with merging this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants