Add 'tdbg workflow unblock' subcommand #6410
Open
+4,528
−3,561
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
The
tdbg
subcommandworkflow unblock
was added, alongside with all of the machinery to add it to AdminService/HistoryService's internal protos.Why?
As part of development of the workflow start delay support for child workflows, @yycptt mentioned it would be useful to have a tool to immediately unblock blocked workflows. Particularly since we're working in this area and may change the behavior of existing block tasks, it seems useful to have an oncall tool ready.
How did you test it?
Screenshot showing the workflow task being scheduled after
unblock workflow
, notice theFirst Workflow Task Backoff
field on the first event compared to following event timestampsPotential risks
Documentation
Is hotfix candidate?