Minor doc update #305
Merged
Minor doc update #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| #### gevent Patching | ||
|
|
||
| When using `gevent.monkey.patch_all()`, asyncio event loops can get messed up, especially those using custom event loops |
There was a problem hiding this comment.
Does it break the event loop in a predictable way? Just wondering if we could put the error here or in the github issue so people searching for the specific error find this.
There was a problem hiding this comment.
Probably, just need research. I admit I have not set up gevent and done all the testing. Can probably just raise an error in client creation if gevent has patched asyncio. I'm just being lazy atm in just adding docs. Given time, I will do full research around #59.
Quinn-With-Two-Ns
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
WorkflowReplayResultandWorkflowReplayResultsproperly (fixes [Bug] temporalio.worker.WorkflowReplayResult(s) not visible #285)