Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unbalanced locks in test server for Nexus #2341

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Fix unbalanced locks in test server for Nexus #2341

merged 2 commits into from
Dec 3, 2024
+20 −6

Conversation

Quinn-With-Two-Ns
Copy link
Contributor

@Quinn-With-Two-Ns Quinn-With-Two-Ns commented Dec 3, 2024 •
edited
Loading

Fix unbalanced locks in test server for Nexus. The issue was the attempt of the task was always using the current attempt not the attempt when the timer was creates as intended.

08:43:47.767 [Timer task] ERROR i.t.i.t.SelfAdvancingTimerImpl - Failed to unlock the timer
java.lang.IllegalStateException: Unbalanced lock and unlock calls: 
Self Advancing Timer Lock Events:
2024-12-03 08:43:47.273	L	  1	TestService constructor
2024-12-03 08:43:47.629	L	    2	scheduleWorkflowTask
2024-12-03 08:43:47.642	L	      3	scheduleWorkflowTask
2024-12-03 08:43:47.645	U	    2	External Caller
2024-12-03 08:43:47.704	U	  1	completeWorkflowTask
2024-12-03 08:43:47.725	L	    2	processScheduleNexusOperation
2024-12-03 08:43:47.725	U	  1	completeWorkflowTask
2024-12-03 08:43:47.755	U	0	failNexusOperation
2024-12-03 08:43:47.755	L	  1	nexusOperationRetryTimer 
2024-12-03 08:43:47.758	U	0	failNexusOperation
2024-12-03 08:43:47.758	L	  1	nexusOperationRetryTimer 
2024-12-03 08:43:47.76	U	0	failNexusOperation
2024-12-03 08:43:47.761	L	  1	nexusOperationRetryTimer 
2024-12-03 08:43:47.764	U	0	failNexusOperation
2024-12-03 08:43:47.765	U	-1	timeoutNexusOperation: 5

@Quinn-With-Two-Ns Quinn-With-Two-Ns marked this pull request as ready for review December 3, 2024 17:13
@Quinn-With-Two-Ns Quinn-With-Two-Ns requested a review from a team as a code owner December 3, 2024 17:13
@Quinn-With-Two-Ns Quinn-With-Two-Ns merged commit cbcf26c into temporalio:master Dec 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdoerner pdoerner pdoerner approved these changes

@cretz cretz cretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Quinn-With-Two-Ns @cretz @pdoerner