Standardized update failure exception #2339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
approved these changes
Dec 2, 2024
Quinn-With-Two-Ns
force-pushed
the
fix-update-exception
branch
from
3d336cc to
97505e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing update with start I noticed that the Java SDK was handling update failures a bit different then other SDKs. Other SDKs always return an update rejection or failure through the update handle. The Java SDK may have returned the update failure (as an exception) on
startUpdateorgetResultdepending on the exact timing andwaitStagethe user selected. After this PR the Java SDK will always return the update failure by getting the result from the handle.