Fix CI after GHA's drop of node16 actions #2338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjameswh
reviewed
Nov 29, 2024
| @@ -92,7 +98,7 @@ jobs: | |||
| distribution: "temurin" | |||
|
|
|||
| - name: Set up Gradle | |||
| uses: gradle/actions/setup-gradle@v3 | |||
| uses: gradle/actions/setup-gradle@v4 | |||
There was a problem hiding this comment.
There are other places we use gradle/actions/setup-gradle@v3. Should update those too.
mjameswh
reviewed
Nov 29, 2024
| docker run \ | ||
| --rm -w /github/workspace -v "$(pwd):/github/workspace" \ | ||
| $(docker build -q ./docker/native-image) \ | ||
| sh -c "./gradlew :temporal-test-server:build" |
There was a problem hiding this comment.
Now that you moved installation stuff to a docker image, you probably no longer need the sh -c and quotes.
There was a problem hiding this comment.
Yep, fixed
mjameswh
reviewed
Nov 29, 2024
| @@ -0,0 +1,8 @@ | |||
| FROM ubuntu:18.04 | |||
There was a problem hiding this comment.
It would be pertinent to add some comments in this docker file explaining to outside readers why we are using an old distro.
There was a problem hiding this comment.
Added a comment
mjameswh
approved these changes
Dec 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build the test server in an ubuntu 18 container