Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove stale import from helloworld #362

Merged
merged 1 commit into from
Aug 23, 2024
Merged

remove stale import from helloworld #362

merged 1 commit into from
Aug 23, 2024

Conversation

yuandrew
Copy link
Contributor

What was changed

The import doesn't seem to be necessary, and the TODO is 2 years old. Removing

Why?

Clean things up

Checklist

  1. Closes

  2. How was this tested:

make ci-build passes locally

  1. Any docs updates needed?

@yuandrew yuandrew requested a review from cretz August 22, 2024 21:05
cretz
cretz approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Yeah now that this is tagged, the go install for @latest in the Makefile works without this. Merge at will.

@yuandrew yuandrew merged commit 4b9e904 into temporalio:main Aug 23, 2024
3 checks passed
@yuandrew yuandrew deleted the remove-stale-todo branch August 23, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cretz cretz cretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuandrew @cretz