Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visit OperatorService methods in interceptor #182

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

bergundy
Copy link
Member

What changed?

  • Visit OperatorService methods in interceptor
  • Reenable generatorcheck Makefile target

Why?

There are payloads in the Nexus EndpointSpec description that need to be visited for completeness.

@bergundy bergundy requested review from a team as code owners October 14, 2024 23:25
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a bit rough that I'm allowed to encrypt endpoint descriptions if I self host but not in cloud. Arguably we should not have made self-hosted descriptions payloads.

@bergundy
Copy link
Member Author

We want to allow encryption in Cloud too. There's a planned breaking change to switch the description field to a payload once we figure out how cloud / and OSS protos are going to be combined.

@bergundy bergundy merged commit 5a9f019 into temporalio:master Oct 15, 2024
3 checks passed
@bergundy bergundy deleted the visit-operator-service branch October 15, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants