Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update protos with account get/update operations #181

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

ennyjfrick
Copy link
Contributor

What changed?

  • Manually updated latest submodule for proto/api-cloud
  • Ran make which updated the account update/get operations in addition to migration from string values to enums

Why?

How did you test it?

Potential risks

@bergundy
Copy link
Member

Not super up-to-date with the status of Cloud protos. @anekkanti / @cretz, do you know if this is safe to upgrade? Is the change from string to enums implemented?

anekkanti
anekkanti previously approved these changes Oct 16, 2024
@bergundy bergundy merged commit 074ad79 into temporalio:master Oct 18, 2024
3 checks passed
@ennyjfrick ennyjfrick deleted the ejf/cloud-account-get-update branch October 22, 2024 18:26
@ennyjfrick
Copy link
Contributor Author

@bergundy thanks for the approval! Would you mind cutting a new release?

@bergundy
Copy link
Member

Hey, I'm just verifying with our Cloud team that we're good to release and will get back to it.

@bergundy
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants