Mitigate injection #115
Merged
Mitigate injection #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace interpolated context variables with default variables used more defensively. This mitigates an attacker naming a branch a command that could run in our runner's context.
cretz
reviewed
Aug 3, 2023
| @@ -10,7 +10,7 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| steps: | |||
| - name: Print build information | |||
| run: "echo head_ref: ${{ github.head_ref }}, ref: ${{ github.ref }}" | |||
| run: 'echo head_ref: "$GITHUB_HEAD_REF", ref: "$GITHUB_REF"' | |||
There was a problem hiding this comment.
You may have to set these as environment variables first
There was a problem hiding this comment.
These are actually set by Github by default and are available to every step in a workflow. You can verify that it's working here: https://github.com/temporalio/api-go/actions/runs/5754549570/job/15600068301?pr=115
There was a problem hiding this comment.
I kind of can't believe that gha has such a security-footgun with no warnings or easy alternatives. I've fixed this in multiple other places. there isn't even a "shell-escape" filter available on substitutions :(
There was a problem hiding this comment.
Ah, sorry! I confused the exec line for the output. Thanks, will merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Replace interpolated github context variables with default variables used more defensively.
Why?
This mitigates an attacker naming a branch a command that could run in our runner's context.
How did you test it?
Ran in my own fork and it was fine in my workflow.
Potential risks
Somehow not printing the build info in the workflow output.