This repository has been archived by the owner on Dec 5, 2023. It is now read-only.
[tem-1559] instance deploy #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChuckHend
approved these changes
Oct 28, 2023
|
|
||
| let config = Config::new(args, &Config::full_path(args)); | ||
| if config.cloud_account.is_none() || config.jwt.is_none() { | ||
| return Err(Box::new(DockerError::new( |
There was a problem hiding this comment.
Does this only run in Docker? If not that Docker error could maybe be confusing.
There was a problem hiding this comment.
That is a good point, this isn't running in Docker (rather locally) and could use its own error object, maybe ConfigError? Thoughts?
| @@ -48,6 +48,17 @@ instances can be started that share a port number. | |||
|
|
|||
| Each instance runs as a Docker container. | |||
|
|
|||
| ## `tembo instance stop` | |||
|
|
|||
| The `instance stop` command allows users to stop their running instances. It requires the name as a parameter. | |||
There was a problem hiding this comment.
yes, the only command that hits the cloud is the instance deploy command at this point
| let jwt = config.jwt.unwrap(); | ||
|
|
||
| let client = reqwest::blocking::Client::new(); | ||
| let request_url = format!("https://api.tembo.io/api/v1/orgs/{org_id}/instances"); |
There was a problem hiding this comment.
Will this be configurable in the future? I could definitely see the need to run our cli against our lower environments.
There was a problem hiding this comment.
that's a good thought, I don't know, the current thinking was to go through the API for everything, what did you have in mind?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the
instance deploycommand.thanks to @ChuckHend for helping me confirm the required attributes!