Fix for SideNav not collapsing when toggling the menu button

The `expanded` prop of the `SideNav` component was incorrectly set as an object instead of a boolean, preventing the nav from being collapsed. Fix the state update so it's providing a boolean as expected.
tektoncd · Apr 22, 2021 · f16fa82 · f16fa82
1 parent 787dbeb
commit f16fa82
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/components/src/components/LabelFilter/LabelFilter.js b/packages/components/src/components/LabelFilter/LabelFilter.js
@@ -151,7 +151,7 @@ class LabelFilter extends Component {
         )}
         <Form onSubmit={this.handleAddFilter} autoComplete="on">
           <Search
-            placeHolderText={searchDescription}
+            placeholder={searchDescription}
             labelText={searchDescription}
             onChange={this.handleChange}
             value={currentFilterValue}

diff --git a/src/containers/App/App.js b/src/containers/App/App.js
@@ -218,9 +218,9 @@ export function App({
               isSideNavExpanded={isSideNavExpanded}
               logoutButton={logoutButton}
               onHeaderMenuButtonClick={() => {
-                setIsSideNavExpanded(prevIsSideNavExpanded => ({
-                  isSideNavExpanded: !prevIsSideNavExpanded
-                }));
+                setIsSideNavExpanded(
+                  prevIsSideNavExpanded => !prevIsSideNavExpanded
+                );
               }}
             />
             <Route path={paths.byNamespace({ path: '/*' })}>