Do not throw from Task.Run callback

teknologi-umum · Feb 3, 2024 · ebe572f · ebe572f
1 parent 57392d5
commit ebe572f
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 4 deletions.
diff --git a/BotNet.CommandHandlers/AI/Gemini/GeminiTextPromptHandler.cs b/BotNet.CommandHandlers/AI/Gemini/GeminiTextPromptHandler.cs
@@ -129,7 +129,7 @@ await telegramBotClient.SendTextMessageAsync(
 						replyToMessageId: textPrompt.Command.MessageId,
 						cancellationToken: cancellationToken
 					);
-					throw;
+					return;
 				}
 
 				// Track thread

diff --git a/BotNet.CommandHandlers/AI/OpenAI/AskCommandHandler.cs b/BotNet.CommandHandlers/AI/OpenAI/AskCommandHandler.cs
@@ -105,7 +105,7 @@ await telegramBotClient.EditMessageTextAsync(
 						parseMode: ParseMode.Html,
 						cancellationToken: cancellationToken
 					);
-					throw;
+					return;
 				}
 
 				// Track thread

diff --git a/BotNet.CommandHandlers/AI/OpenAI/OpenAIImageGenerationPromptHandler.cs b/BotNet.CommandHandlers/AI/OpenAI/OpenAIImageGenerationPromptHandler.cs
@@ -77,6 +77,8 @@ await _telegramBotClient.DeleteMessageAsync(
 				} catch (OperationCanceledException) {
 					// Terminate gracefully
 					// TODO: tie up loose ends
+				} catch (Exception exc) {
+					_logger.LogError(exc, "Could not handle command");
 				}
 			});
 

diff --git a/BotNet.CommandHandlers/AI/OpenAI/OpenAIImagePromptHandler.cs b/BotNet.CommandHandlers/AI/OpenAI/OpenAIImagePromptHandler.cs
@@ -200,7 +200,7 @@ await telegramBotClient.EditMessageTextAsync(
 						parseMode: ParseMode.Html,
 						cancellationToken: cancellationToken
 					);
-					throw;
+					return;
 				}
 
 				// Track thread

diff --git a/BotNet.CommandHandlers/AI/OpenAI/OpenAITextPromptHandler.cs b/BotNet.CommandHandlers/AI/OpenAI/OpenAITextPromptHandler.cs
@@ -169,7 +169,7 @@ await telegramBotClient.EditMessageTextAsync(
 						parseMode: ParseMode.Html,
 						cancellationToken: cancellationToken
 					);
-					throw;
+					return;
 				}
 
 				// Track thread
-Original file line number
+Diff line change
@@ Expand Up / @@ -129,7 +129,7 @@ await telegramBotClient.SendTextMessageAsync( @@
     						replyToMessageId: textPrompt.Command.MessageId,
     						cancellationToken: cancellationToken
     					);
-    					throw;
+    					return;
     				}
     				// Track thread
@@ Expand Down @@