Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug #221120: [WEB UI] : Logo is not aligned properly #1937

Open
wants to merge 6 commits into
base: release-2.8.1
Choose a base branch
from

Conversation

snehalsabade
Copy link
Contributor

@snehalsabade snehalsabade commented Jul 18, 2024

https://tracker.tekdi.net/issues/221120

I have ensured that following Pull Request Checklist is taken care of before sending this PR

  • Code is formatted as per format decided
  • Updated acceptance criteria in tracker
  • Updated test cases in test-cases-tracker

Summary by CodeRabbit

  • New Features

    • Enhanced login page with improved responsive design for better user experience on different screen sizes.
    • Introduced conditional rendering for images to adapt based on the window's width.
  • Style

    • Adjusted styling and positioning of images and text components on the login page.

Copy link

coderabbitai bot commented Jul 18, 2024

Walkthrough

The recent changes to Login.js enhance the component's code organization and responsiveness by integrating useWindowDimensions from "react-native-web". The updates involve restructuring the JSX layout, implementing conditional rendering of images based on the window width, and refining styles for improved visual alignment. These modifications collectively boost the component's adaptability for various screen sizes.

Changes

File Summary of Changes
modules/auth/src/pages/Login.js - Added import for useWindowDimensions from "react-native-web".
- Removed width from useWindowSize, using useWindowDimensions instead.
- Commented out imports for Motif_EG.
- Introduced conditional rendering of images based on width.
- Reorganized JSX structure.
- Enhanced styling and positioning of elements for better responsiveness.

Sequence Diagram(s)

No sequence diagrams are necessary as the changes primarily focus on code organization and styling adjustments without altering the core functionality or introducing new features.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 523e2e4 and 1f8e563.

Files ignored due to path filters (4)
  • apps/front-end/public/images/logos/Motifs/360.svg is excluded by !**/*.svg
  • apps/front-end/public/images/logos/Motifs/390.svg is excluded by !**/*.svg
  • apps/front-end/public/images/logos/Motifs/393.svg is excluded by !**/*.svg
  • apps/front-end/public/images/logos/Motifs/412.svg is excluded by !**/*.svg
Files selected for processing (1)
  • modules/auth/src/pages/Login.js (5 hunks)
Additional comments not posted (5)
modules/auth/src/pages/Login.js (5)

29-31: Imports updated: Ensure unused imports are removed.

The import for useWindowDimensions is necessary for the changes. The commented-out imports for Motif_EG should be removed if they are no longer needed.


80-81: Ensure consistent usage of window dimensions.

The useWindowSize is partially replaced with useWindowDimensions. Ensure that the height value is still correctly used and that the width value is consistently applied.


172-227: Improve responsive design logic.

The changes in the JSX elements aim to improve the responsive design. Ensure that the width conditions cover all necessary cases and that the images are correctly displayed based on the screen width.


231-233: Repositioning of the heading element.

The FrontEndTypo.H1 element is repositioned. Ensure that this change improves the layout and aligns with the design requirements.


256-256: Ensure form validation and error handling.

The form elements and validation logic are crucial for user experience. Ensure that the validation and error handling are correctly implemented and that the form elements are properly styled.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 1f8e563 and 684072a.

Files selected for processing (1)
  • modules/auth/src/pages/Login.js (5 hunks)
Files skipped from review as they are similar to previous changes (1)
  • modules/auth/src/pages/Login.js

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 684072a and 4562288.

Files selected for processing (1)
  • modules/auth/src/pages/Login.js (5 hunks)
Files skipped from review as they are similar to previous changes (1)
  • modules/auth/src/pages/Login.js

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4562288 and fa67d58.

Files ignored due to path filters (1)
  • apps/front-end/public/images/logos/en/Motiflogo300*300.svg is excluded by !**/*.svg
Files selected for processing (1)
  • modules/auth/src/pages/Login.js (5 hunks)
Files skipped from review as they are similar to previous changes (1)
  • modules/auth/src/pages/Login.js

@sagarkoshti1990 sagarkoshti1990 changed the base branch from feat-register-revamp to release-2.3.1 July 22, 2024 07:15
@sagarkoshti1990 sagarkoshti1990 changed the base branch from release-2.3.1 to release-2.4.0 July 24, 2024 13:36
@sagarkoshti1990 sagarkoshti1990 changed the base branch from release-2.5.0 to release-2.6.0 August 30, 2024 05:45
@sagarkoshti1990 sagarkoshti1990 changed the base branch from release-2.6.0 to release-2.7.0 September 9, 2024 06:16
@sagarkoshti1990 sagarkoshti1990 changed the base branch from release-2.7.0 to release-2.8.0 September 24, 2024 06:25
@Pritams43 Pritams43 changed the base branch from release-2.8.0 to release-2.8.1 November 21, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants