Pursue a part of #1030, so it becomes part of the next release #1074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1074 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 115 115
Lines 9263 9263
Branches 2184 2184
=========================================
Hits 9263 9263 ☔ View full report in Codecov by Sentry. |
tefra
reviewed
Sep 12, 2024
|
|
You made my Friday 13th well ;-) |
skinkie
added a commit
to skinkie/reference
that referenced
this pull request
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📒 Description
Considering you are writing a very big tree, you don't want to materialise that tree before it ends up in a file in a list first. Ideally the entire subtree should only be rendered just in time.
🔗 What I've Done
I have allowed a Generator to be handled as a List.
💬 Comments
This issue does not resolve the question of #1030 to make the type annotations an
Iterable. But I want the functionality to allow a Generator as input be part of the next release so we can use the stock xsData.🛫 Checklist