Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Unnest classes should update inner classes recursively #1047

Merged
merged 1 commit into from
Jun 15, 2024
Merged

Conversation

tefra
Copy link
Owner

@tefra tefra commented May 27, 2024

📒 Description

Forward references can point to inner or outer classes since v24.5, the unnest handler isn't dealing with that, raising errors when unnest classes config is enabled.

Resolves #1046

🔗 What I've Done

Write a description of the steps taken to resolve the issue

💬 Comments

A place to write any comments to the reviewer.

🛫 Checklist

Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (791a98e) to head (c022af6).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1047   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          115       115           
  Lines         9222      9231    +9     
  Branches      2178      2178           
=========================================
+ Hits          9222      9231    +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tefra
Copy link
Owner Author

tefra commented May 27, 2024

We have an issue in classes with multiple nested classes with the same name.... sometimes xsd can be so cruel

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@tefra tefra merged commit 25cea60 into main Jun 15, 2024
15 checks passed
@tefra tefra deleted the fix-1046 branch June 15, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot generate nested group references with --unnest-classes
1 participant