Merge pull request #384 from owsy/encode-numeric-string

Encoding Numeric Strings
tedious · Feb 21, 2022 · 7a898d8 · 7a898d8
2 parents 8935156 + 858f9a3
commit 7a898d8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/Stash/Utilities.php b/src/Stash/Utilities.php
@@ -34,15 +34,17 @@ public static function encoding($data)
                 return 'bool';
             }
 
+            if (is_string($data)) {
+                return 'string';
+            }
+
             if (is_numeric($data)) {
                 if (is_numeric($data) && ($data >= 2147483648 || $data < -2147483648)) {
                     return 'serialize';
                 } else {
                     return 'numeric';
                 }
             }
-
-            return 'string';
         }
 
         return 'serialize';

diff --git a/tests/Stash/Test/UtilitiesTest.php b/tests/Stash/Test/UtilitiesTest.php
@@ -25,6 +25,8 @@ public function testEncoding()
         $this->assertEquals(Utilities::encoding(true), 'bool', 'encoding recognized \'true\' boolean.');
         $this->assertEquals(Utilities::encoding(false), 'bool', 'encoding recognized \'false\' boolean');
 
+        $this->assertEquals(Utilities::encoding('1'), 'string', 'encoding recognized \'1\' string.');
+        $this->assertEquals(Utilities::encoding('1.2'), 'string', 'encoding recognized \'1.2\' string.');
         $this->assertEquals(Utilities::encoding('String of doom!'), 'string', 'encoding recognized string scalar');
 
         $this->assertEquals(Utilities::encoding(234), 'numeric', 'encoding recognized integer scalar');