[TMA-630][haoliu & llr] Make pcall right.

techops-staffing · Feb 26, 2019 · 9314e5c · 9314e5c
1 parent 49a6613
commit 9314e5c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/kong/plugins/okta-auth/access.lua b/kong/plugins/okta-auth/access.lua
@@ -38,7 +38,7 @@ local function make_oidc(token_data)
     ngx.log(ngx.DEBUG, " Get Oidc label Success. oidc_label: ", oidc_label)
   else
     ngx.log(ngx.ERR, " Get Oidc label failed.")
-    oidc_label = ''
+    oidc_label = " "
   end
 
   oidc["Lab"] = oidc_label

diff --git a/kong/plugins/okta-auth/okta_api.lua b/kong/plugins/okta-auth/okta_api.lua
@@ -61,12 +61,12 @@ local function fetch_objc_label(oidc_id)
 
     local url = base_url .. '/api/v1/apps/' .. oidc_id
     local headers = get_Oidc_headers()
-    local pok, status_code, response_body, response_headers = pcall(send_request(
+    local pok, status, response_body, response_headers = pcall(send_request,
             url, "GET", headers, body_params
-    ))
+    )
 
-    if not pok or status_code ~= 200 or not response_body then
-        ngx.log(ngx.ERR, "Assemble OIDC Label failed with :status_code ", status_code)
+    if not pok or status ~= 200 or not response_body then
+        ngx.log(ngx.ERR, "Assemble OIDC Label failed, because ", status)
         return nil
     end