Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/fix tests #966

Merged
merged 9 commits into from
Oct 14, 2024
Merged

Chore/fix tests #966

merged 9 commits into from
Oct 14, 2024

Conversation

raphael-arce
Copy link
Contributor

@raphael-arce raphael-arce commented Oct 11, 2024 •
edited
Loading

needs: technologiestiftung/giessdenkiez-de-postgres-api#273

⚠️ Warning ⚠️
Env vars for local development have changed, they have been updated in 1P

  • fixed tests
  • improved test structure (moved to own test folder, moved test configs (e2e, unit) to own folder)
  • fixed bug where username was not checked during registration (used new function from feat: allow anon to see all profiles giessdenkiez-de-postgres-api#273)
  • extracted create release step from CI pipeline in own workflow that can be manually executed

@vercel Vercel
Copy link

vercel bot commented Oct 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
giessdenkiez-de ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2024 2:05pm

@raphael-arce raphael-arce changed the base branch from main to staging October 11, 2024 18:58
@raphael-arce
feat: move/update/fix tests
649ccff 
Signed-off-by: Raphael Arce <[email protected]>
@raphael-arce
docs: update .env.sample
ed44729 
Signed-off-by: Raphael Arce <[email protected]>
aeschi
aeschi approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@aeschi aeschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 only one comment

src/components/map/hooks/use-map-setup.tsx Show resolved Hide resolved
@raphael-arce raphael-arce marked this pull request as ready for review October 14, 2024 14:13
@raphael-arce raphael-arce merged commit 764d347 into staging Oct 14, 2024
4 checks passed
@raphael-arce raphael-arce deleted the chore/fix-tests branch October 14, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeschi aeschi aeschi approved these changes

@Jaszkowic Jaszkowic Awaiting requested review from Jaszkowic Jaszkowic is a code owner

@vogelino vogelino Awaiting requested review from vogelino vogelino is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raphael-arce @aeschi