Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(staging to prod) feat: age classification per district (#955) #956

Merged
merged 10 commits into from
Oct 14, 2024
Merged

Conversation

Jaszkowic
Copy link
Collaborator

  • feat: draft

  • feat: baby trees limit for special districts

  • feat: apply special district logic for age classification

  • feat: use latest DWD

  • feat: tests for special trees

  • chore: remove @ff6347 from codeowner - thank you for your service

* feat: draft

* feat: baby trees limit for special districts

* feat: apply special district logic for age classification

* feat: use latest DWD

* feat: tests for special trees

* chore: remove @ff6347 from codeowner - thank you for your service
Copy link

vercel bot commented Sep 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
giessdenkiez-de ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2024 0:42am

aeschi
aeschi previously approved these changes Sep 30, 2024
Copy link
Contributor

@aeschi aeschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@Jaszkowic
Copy link
Collaborator Author

still needs text changes, not ready to merge

@Jaszkowic Jaszkowic marked this pull request as draft September 30, 2024 14:39
@Jaszkowic Jaszkowic marked this pull request as ready for review October 9, 2024 07:45
aeschi
aeschi previously approved these changes Oct 9, 2024
Copy link
Contributor

@aeschi aeschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node.js CI Test was still failing otherwise LGTM!

* feat: add filter toggle and functionality

* feat: filter functionality

* feat: fetch water_sum and todaysWaterings

* fix: logic error

* feat: use feature state instead of todaysWaterings array

---------

Co-authored-by: Jonas Jaszkowic <[email protected]>
* fix: water and age hint

* fix: add english

* fix: bad hook

* fix: check if window is defined

* fix: tests

* fix: missing return

* fix: display district name

* feat: make trees turn yellow sooner

* fix: logic
@Jaszkowic
Copy link
Collaborator Author

we deploy Monday, 14.10.

* feat: text changes splash

* feat: add winter version of tree water needs

* feat: set last waterings as default true

* feat: only set last waterings open when waterings exist

* feat: cleanup

* feat: text changes

* feat: change actionTitle for winter

* feat: adjust tests to new wording and period switch

* feat: split text logic for age and water needs

* feat: add space before show more

* feat: refactor tree water needs (#963)

* feat: refactor tree water needs

* feat: useIsInVegetationPeriod as function

* feat: adjust date to include full october
@Jaszkowic Jaszkowic merged commit 69a9e58 into main Oct 14, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants