Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/legend and bar chart #884

Merged
merged 1 commit into from
May 2, 2024
Merged

Fix/legend and bar chart #884

merged 1 commit into from
May 2, 2024

Conversation

raphael-arce
Copy link
Contributor

@raphael-arce raphael-arce commented May 2, 2024 •
edited
Loading

This PR fixes:

  • the position of the legend (e.g. hides it when the filter view is open)
  • the bug where the bar chart filter bars get reversed when resetting

@vercel Vercel
Copy link

vercel bot commented May 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
giessdenkiez-de ✅ Ready (Inspect) Visit Preview May 2, 2024 8:05am
new-giessdenkiez-de ✅ Ready (Inspect) Visit Preview May 2, 2024 8:05am

@raphael-arce raphael-arce changed the base branch from master to staging May 2, 2024 08:06
Jaszkowic
Jaszkowic approved these changes May 2, 2024
View reviewed changes
Copy link
Collaborator

@Jaszkowic Jaszkowic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raphael-arce raphael-arce merged commit c3cb529 into staging May 2, 2024
5 of 7 checks passed
@raphael-arce raphael-arce deleted the fix/legend-and-bar-chart branch May 2, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jaszkowic Jaszkowic Jaszkowic approved these changes

@ff6347 ff6347 Awaiting requested review from ff6347

@vogelino vogelino Awaiting requested review from vogelino vogelino is a code owner

@aeschi aeschi Awaiting requested review from aeschi aeschi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raphael-arce @Jaszkowic