[Feature] Use .json config file for arguments #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
m3yevn
requested changes
Jul 13, 2020
| logInfo("Committing for " + amount + " times"); | ||
| logInfo("Do not terminate this process!"); | ||
|
|
||
| const hasContributors = CheckIfArgIncludes("--contributors"); |
There was a problem hiding this comment.
arguments should be remained also, if there is no config file, argument is used.
| import { writeFileSync, existsSync } from "fs"; | ||
| import { LoadService } from "../OtherServices/LoadService"; | ||
| import { commitGen } from "../../config/gitlestial.config"; |
There was a problem hiding this comment.
my meaning is not importing the config file, but more like reading it from the directory on which user is running gitlestial command,
e.g,
test_app has gitlestial.config.js in the root directory.
so we can
$ cd test_app
$ gitlestial commit-gen
it will trigger the same as
$ gitlestial commit-gen --amount 100 --contributors [email protected],[email protected] -am "just a test"
if the gitlestial.config.js has
module.exports = {
commitGen: {
amount: 100,
contributors: ["[email protected]","[email protected]"],
message: "just a test",
},
};
it's not a static import but a dynamic reading of a config file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pull request for #3.
Don't merge to master. Will need to test first.