Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Use .json config file for arguments #3

Open
1 task done
m3yevn opened this issue Jun 8, 2020 · 4 comments
Open
1 task done

[Feature] Use .json config file for arguments #3

m3yevn opened this issue Jun 8, 2020 · 4 comments
Assignees

Comments

@m3yevn
Copy link
Member

m3yevn commented Jun 8, 2020

  • check inside project directory for gitlestial.config.json or .js to read configurations so that user won't be necessary to type in CLI for committing.
@m3yevn m3yevn changed the title feature/Use .json config file for arguments [Feature] Use .json config file for arguments Jun 13, 2020
@m3yevn m3yevn assigned m3yevn and PyaeHlianMoe and unassigned m3yevn Jun 13, 2020
@m3yevn m3yevn assigned m3yevn and unassigned PyaeHlianMoe Jun 27, 2020
@m3yevn m3yevn modified the milestone: Version 1.0.6 Jun 27, 2020
@m3yevn m3yevn assigned PyaeHlianMoe and unassigned m3yevn Jul 2, 2020
@m3yevn
Copy link
Member Author

m3yevn commented Jul 3, 2020

need to add a service which will read gitlestial.config.js (by default) if specify the specified path file, to get all arguments to perform operation

@PyaeHlianMoe
Copy link
Member

PyaeHlianMoe commented Jul 10, 2020

Default
In default, config file will exist in the same directory as LICENSE. I will give the file name as gitlestial-config.json. Can execute by running gitlestial run command.

User specified config file path
In this scenario, user can specify their own config file path using this command. gitlestial run --config <config_file path>.

gitlestial-config.json format

{
    "npmCommands": [
        "npm install",
        "npm link"
    ],
    "gitCommands": [
        "git add",
        "gitlestial commit-gen",
        "git push"
    ]
}

@m3yevn
Copy link
Member Author

m3yevn commented Jul 10, 2020

Default
In default, config file will exist in the same directory as LICENSE. I will give the file name as gitlestial-config.json. Can execute by running gitlestial run command.

User specified config file path
In this scenario, user can specify their own config file path using this command. gitlestial run --config <config_file path>.

gitlestial-config.json format

{
    "npmCommands": [
        "npm install",
        "npm link"
    ],
    "gitCommands": [
        "git add",
        "gitlestial commit-gen",
        "git push"
    ]
}

no, what i mean is gitlestial.config.js will contain all the arguments for git commit-gen or anything
can we make it as gitlestial.config.js to follow what usual cli tools name it e.g webpack.config.js

can reference here https://gist.github.com/iamshaunjp/a1c8fb653ddd5d27c3e38ab55e3c0a44

example js config file

module.exports = {
 commitGen: {
 amount: 100,
 contributors: [[email protected],[email protected]],
 message: "just triggering commits",
}
}

@m3yevn
Copy link
Member Author

m3yevn commented Jul 10, 2020

the idea is to make user convenient by configuring the arguments like --amount 100 --contributors [email protected],[email protected] -am "triggering commits"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants