Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[๐Ÿ”€ merge] [3์ฐจ] ์ฝ”๋“œ ๋ฆฌํŽ™ํ† ๋ง ์‚ฌํ•ญ ์ ์šฉ (3) #188

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

jsoonworld
Copy link
Member

  • [๐Ÿ”€ merge] [3์ฐจ] ์Šคํ”„๋ฆฐํŠธ ์ฝ”๋“œ ๋ฆฌํŽ™ํ† ๋ง ์‚ฌํ•ญ์„ ์ ์šฉํ•ฉ๋‹ˆ๋‹ค.

jsoonworld and others added 18 commits December 1, 2024 11:51
- InternshipRepository์— findFilteredInternshipsWithScrapInfo ๋ฉ”์„œ๋“œ ์ถ”๊ฐ€ํ•˜์—ฌ QueryDSL ๊ธฐ๋ฐ˜์œผ๋กœ ์Šคํฌ๋žฉ ์ •๋ณด์™€ ํ•จ๊ป˜ ๊ณต๊ณ  ๋ฐ์ดํ„ฐ๋ฅผ ์กฐํšŒ.
- HomeServiceImpl์—์„œ ๊ธฐ์กด ์Šคํฌ๋žฉ ์ •๋ณด ๋กœ์ง์„ ์ œ๊ฑฐํ•˜๊ณ , ์ƒˆ๋กœ ์ถ”๊ฐ€๋œ ํ†ตํ•ฉ ๋ฉ”์„œ๋“œ๋กœ ๋Œ€์ฒด.
- HomeService ์„ฑ๋Šฅ ํ…Œ์ŠคํŠธ ์ถ”๊ฐ€ํ•˜์—ฌ ๋‹ค์–‘ํ•œ ์กฐ๊ฑด์—์„œ ์„ฑ๋Šฅ ํ™•์ธ:
  - 1๊ฐœ, 100๊ฐœ, 1000๊ฐœ์˜ ๊ณต๊ณ  ๋ฐ์ดํ„ฐ๋ฅผ ๊ธฐ๋ฐ˜์œผ๋กœ ์‘๋‹ต ์‹œ๊ฐ„ ์ธก์ •.
- DTO ๋งคํ•‘ ๋กœ์ง์„ ๊ฐ„์†Œํ™”ํ•˜๊ณ , isScrapped ๋กœ์ง์„ ๋ณ„๋„ ๋ฉ”์„œ๋“œ๋กœ ์ถ”์ถœํ•˜์—ฌ ๊ฐ€๋…์„ฑ ๊ฐœ์„ .
[โ™ป๏ธ refactor/#173]: updateUserFilter ๋ฉ”์„œ๋“œ ๋ฆฌํŒฉํ† ๋ง
- ๋ณ€๊ฒฝ ์ „/ํ›„์˜ query ๋กœ์ง์— ๋Œ€ํ•œ ๋ถ€ํ•˜ํ…Œ์ŠคํŠธ๋ฅผ ์ง„ํ–‰ํ•˜๊ธฐ ์œ„ํ•ด JMeter ํ™œ์šฉํ–ˆ์Šต๋‹ˆ๋‹ค.
- ๋Œ€ํ‘œ์ ์ธ ๋„๊ตฌ์ธ k6, nGrinder, JMeter ์ค‘ JMeter๋ฅผ ์„ ํƒํ•œ ์ด์œ ๋Š” HTML ํ˜•์‹์˜ ๋ณด๊ณ ์„œ๊ฐ€ ์ž˜ ์ •๋ฆฌ๋˜์–ด ์žˆ๊ณ , ๋ ˆํผ๋Ÿฐ์Šค์˜ ๊ทœ๋ชจ์™€ ์‚ฌ์šฉ์„ฑ ์ธก๋ฉด์„ ๊ณ ๋ คํ–ˆ์Šต๋‹ˆ๋‹ค.
- Scrap ์ •๋ณด๋ฅผ ํ•œ ๋ฒˆ์— ์กฐํšŒ ํ•˜๋„๋ก ๋ณ€๊ฒฝ (QueryDSL Tuple ํ™œ์šฉ)
- Enum Color์˜ ๋‚ด๋ถ€ ๋ฉ”์„œ๋“œ๋ฅผ ํ™œ์šฉํ•ด์„œ ์ƒ‰์ƒ๊ฐ’์„ ๋ถˆ๋Ÿฌ์˜ค๋„๋ก ์ˆ˜์ •
- ๋ถˆํ•„์š”ํ•œ ๋ฉ”์„œ๋“œ๋ฅผ ์ œ๊ฑฐํ•˜๊ณ , isScrapped ๋กœ์ง์„ ์ข€ ๋” ๋‹จ์ˆœํ•˜๊ฒŒ ์ˆ˜์ •
[โ™ป๏ธ refactor/#175]: ๊ณต๊ณ  ๋ฐ์ดํ„ฐ ์กฐํšŒ ์„ฑ๋Šฅ ์ตœ์ ํ™” ๋ฐ N+1 ๋ฌธ์ œ ํ•ด๊ฒฐ
[โ™ป๏ธ refactor] N+1 ๋ฌธ์ œ ํ•ด๊ฒฐ ๋ฐ HomeServiceImpl ์„ฑ๋Šฅ ๊ฐœ์„ 
- ํ™ˆ - ๋”ฑ ๋งž๋Š” ๋Œ€ํ•™์ƒ ์ธํ„ด ๊ณต๊ณ  API ์—์„œ Query Parameter๋กœ ์ „๋‹ฌ๋˜๋Š” year, month๋ฅผ ์‚ญ์ œํ•˜๊ณ , ์‚ฌ์šฉ์ž์˜ ํ•„ํ„ฐ๋ง ์ •๋ณด๋ฅผ ์ด์šฉํ•ด ๊ณต๊ณ ๋“ค์„ ํ•„ํ„ฐ๋งํ•˜์—ฌ ์ „๋‹ฌํ•  ์ˆ˜ ์žˆ๋„๋ก ๋กœ์ง์„ ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค.
[โ™ป๏ธ refactor/#179] ๋‚˜์—๊ฒŒ ๋”ฑ ๋งž๋Š” ๋Œ€ํ•™์ƒ ์ธํ„ด ๊ณต๊ณ  API Query Parameter ์žฌ์กฐ์ •
[๐Ÿ”€ merge] [3์ฐจ] ์ฝ”๋“œ ๋ฆฌํŽ™ํ† ๋ง ์‚ฌํ•ญ ์ ์šฉ
- ์‚ฌ์šฉ์ž์˜ ์ง๋ฌด ํ•„ํ„ฐ๋ง(jobType)๊ณผ ๊ณ„ํš ํ•„ํ„ฐ๋ง ์‚ฌํ•ญ์„ ๋ชจ๋‘ ํ•œ๋ฒˆ์— ์ˆ˜์ •ํ•˜๋Š” ํ•„ํ„ฐ๋ง ์ œ์„ค์ • API์™€ ํ•„ํ„ฐ๋ง ์ •๋ณด๋ฅผ ๋ถˆ๋Ÿฌ์˜ค๋Š” API๋ฅผ ๊ตฌํ˜„ํ•ฉ๋‹ˆ๋‹ค.
[โœจ feat] ์ง๋ฌดํ•„ํ„ฐ๋ง, ์‚ฌ์šฉ์ž ํ•„ํ„ฐ๋ง ์ •๋ณด, ํ•„ํ„ฐ๋ง ์žฌ์„ค์ •(์ง๋ฌด, ๊ณ„ํš) API ๊ตฌํ˜„
[๐Ÿ”€ merge] [3์ฐจ] ์ฝ”๋“œ ๋ฆฌํŽ™ํ† ๋ง ์‚ฌํ•ญ ์ ์šฉ (2)
- ๊ณต๊ณ  ์กฐํšŒ API์— ํŽ˜์ด์ง• ๊ธฐ๋Šฅ ์ถ”๊ฐ€
  - Pageable์„ ํ™œ์šฉํ•œ ํŽ˜์ด์ง• ์ฒ˜๋ฆฌ ๊ตฌํ˜„
  - `@PageableDefault`๋ฅผ ํ†ตํ•ด ๊ธฐ๋ณธ ํŽ˜์ด์ง€ ํฌ๊ธฐ ์„ค์ •
- DTO ์ˆ˜์ •
  - HomeAnnouncementsResponseDto์— ํŽ˜์ด์ง• ๊ด€๋ จ ํ•„๋“œ ์ถ”๊ฐ€ (`totalPages`, `hasNext`)
- Repository ์ˆ˜์ •
  - ํŽ˜์ด์ง• ์ฒ˜๋ฆฌ๋œ ๊ณต๊ณ  ๋ฐ์ดํ„ฐ๋ฅผ ๋ฐ˜ํ™˜ํ•˜๋„๋ก ์ฟผ๋ฆฌ ์ˆ˜์ •
  - `Page<Tuple>`๋ฅผ ํ™œ์šฉํ•œ ํŽ˜์ด์ง• ๋กœ์ง ๊ตฌํ˜„
- Service ๋กœ์ง ๋ฆฌํŒฉํ† ๋ง
  - ๊ณตํ†ต ๋ฉ”์„œ๋“œ ๋ถ„๋ฆฌ (`getUserById`, `createEmptyResponse` ๋“ฑ)
  - Color ๊ฐ’ ๋ฐ ์Šคํฌ๋žฉ ์—ฌ๋ถ€ ์ฒ˜๋ฆฌ ๋ฉ”์„œ๋“œ ๋ถ„๋ฆฌ (`isScrapped`, `determineColorValue`)
- Swagger ์ˆ˜์ •
  - API ๋ฌธ์„œ์— ํŽ˜์ด์ง• ํŒŒ๋ผ๋ฏธํ„ฐ ๋ฐ˜์˜
[โœจfeat/#185]: ๊ณต๊ณ  ์กฐํšŒ ํŽ˜์ด์ง€๋„ค์ด์…˜ ๊ธฐ๋Šฅ ๋„์ž… ๋ฐ ์„œ๋น„์Šค ๋กœ์ง ๊ฐœ์„ 
[๐Ÿ”€ merge] [3์ฐจ] ์ฝ”๋“œ ๋ฆฌํŽ™ํ† ๋ง ์‚ฌํ•ญ ์ ์šฉ (3)
@jsoonworld jsoonworld added ๐Ÿ”€ย merge ๋‹ค๋ฅธ ๋ธŒ๋žœ์น˜์™€ ๋ณ‘ํ•ฉ ๐ŸฆŠ์žฅ์ˆœ๐ŸฆŠ labels Dec 21, 2024
@jsoonworld jsoonworld self-assigned this Dec 21, 2024
junggyo1020 and others added 4 commits December 29, 2024 23:24
- ์˜จ๋ณด๋”ฉ ๊ฑด๋„ˆ๋›ฐ๊ธฐ ์‹œ, ํด๋ผ์—์„œ null๊ฐ’์„ ๋ฐ›์•„์˜ฌ ์ˆ˜ ์žˆ๋„๋ก API๋ฅผ ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค
[๐Ÿ”ฅ !hotfix] ์ง๋ฌดํ•„ํ„ฐ๋ง, ์‚ฌ์šฉ์ž ํ•„ํ„ฐ๋ง ์ •๋ณด, ํ•„ํ„ฐ๋ง ์žฌ์„ค์ •(์ง๋ฌด, ๊ณ„ํš) API ์ˆ˜์ •
[๐Ÿ”ฅ !hotfix] ํ•„ํ„ฐ๋ง ์ •๋ณด๊ฐ€ ๋ชจ๋‘ null์ด๋ฉด ์ „์ฒด ๊ณต๊ณ ๊ฐ€ ๋ณด์ด๋„๋ก ์ˆ˜์ •
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
๐Ÿ”€ย merge ๋‹ค๋ฅธ ๋ธŒ๋žœ์น˜์™€ ๋ณ‘ํ•ฉ ๐ŸฆŠ์žฅ์ˆœ๐ŸฆŠ
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants