[FX-1451] Add unit tests for RosettaPinSubmitter and RosettaPinElement #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djoksimo
requested review from
owenkim,
ForageRob,
dleis612,
devinmorgan and
evanfreeze
as code owners
djoksimo
commented
Jun 11, 2024
| @@ -26,10 +26,11 @@ import okhttp3.RequestBody | |||
| import okhttp3.RequestBody.Companion.toRequestBody | |||
| import org.json.JSONObject | |||
|
|
|||
| internal class ForagePinSubmitter( | |||
| internal class RosettaPinSubmitter( | |||
There was a problem hiding this comment.
Renamed for consistency with POS code and for less ambiguity while we have dual redundancy
djoksimo
commented
Jun 11, 2024
Comment on lines
94
to
95
| private fun buildVaultUrl(path: String): HttpUrl = | ||
| VAULT_BASE_URL.toHttpUrlOrNull()!! | ||
| StopgapGlobalState.envConfig.vaultBaseUrl.toHttpUrlOrNull()!! |
There was a problem hiding this comment.
Copied fix from here
djoksimo
changed the title
djoksimo
commented
Jun 11, 2024
There was a problem hiding this comment.
Renamed to RosettaPinElement. The term "wrapper" applies to Basis Theory, but we're not wrapping much in RosettaPinElement
evanfreeze
approved these changes
Jun 11, 2024
| } | ||
|
|
||
| @Test | ||
| fun `Basis Theory responds with a malformed error`() = runTest { |
There was a problem hiding this comment.
^Rosetta rather than BT
| val path = buildMockPaymentCapturePath(paymentRef) | ||
|
|
||
| return VaultProxyRequest.emptyRequest() | ||
| .setHeader(ForageConstants.Headers.X_KEY, "22320ce0-1a3c-4c64-970c-51ed7db34548") |
There was a problem hiding this comment.
Do we need to send this X-KEY header?
There was a problem hiding this comment.
We don't need the X-KEY header for Rosetta (omitted here), but on this line, I'm emulating the headers that are set by the Abstract /Base Vault Submitter, I'll update a comment to capture this context in the code
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...ndroid/src/main/java/com/joinforage/forage/android/ecom/ui/vault/forage/RosettaPinElement.kt
Dismissed
Show dismissed
Hide dismissed
...ndroid/src/main/java/com/joinforage/forage/android/ecom/ui/vault/forage/RosettaPinElement.kt
Dismissed
Show dismissed
Hide dismissed
...ndroid/src/main/java/com/joinforage/forage/android/ecom/ui/vault/forage/RosettaPinElement.kt
Dismissed
Show dismissed
Hide dismissed
...ndroid/src/main/java/com/joinforage/forage/android/ecom/ui/vault/forage/RosettaPinElement.kt
Dismissed
Show dismissed
Hide dismissed
djoksimo
commented
Jun 12, 2024
| import com.joinforage.forage.android.core.ui.textwatcher.PinTextWatcher | ||
| import com.joinforage.forage.android.ecom.services.vault.forage.RosettaPinSubmitter | ||
|
|
||
| internal class RosettaPinElement @JvmOverloads constructor( |
There was a problem hiding this comment.
@devinmorgan can this file be moved to core instead of ecom ?
This can also happen in a future PR as this is an internal change, but vocalizing now for visibility.
There was a problem hiding this comment.
The main blocker right now is that this file depends on:
import com.joinforage.forage.android.ecom.services.vault.forage.RosettaPinSubmitter
which is an ecom file. So in theory, yes, this file ought to live in core since it's used in both Ecom and Pos but this may be more appropriate to do in a follow on PR since it's slightly move inovled. Nice callout!
djoksimo
force-pushed
the
evan/fx-1368-re-introduce-the-foragevaultwrapper-into-the-coreui-module
branch
from
6bcfec6 to
8a08eed
Compare
djoksimo
force-pushed
the
danilo/fx-1451-unit-tests-for-foragepinsubmitter-and-forage-pin-ui-element
branch
from
9cb2565 to
4299337
Compare
djoksimo
merged commit 1b0e23e
into
evan/fx-1368-re-introduce-the-foragevaultwrapper-into-the-coreui-module
6 checks passed
djoksimo
added a commit
that referenced
this pull request
Jun 17, 2024
* add ForageResponseParser * add ForagePinSubmitter * add ForageVaultWrapper * use ForageVaultWrapper in ForagePINEditText * flip logic around to reduce unnecessary diff * update comment * Update forage-android/src/main/java/com/joinforage/forage/android/ecom/ui/ForagePINEditText.kt Co-authored-by: Danilo Joksimovic <[email protected]> * Rotate sample app value for customer-id Force re-tokenization of test cards in mobile-qa-tets * [FX-1451] Add unit tests for RosettaPinSubmitter and RosettaPinElement (#261) * Add unit tests for ForagePinSubmitter * Add RosettaPinElement tests! * Add test for checking default text size * Bring parity to corner styles * Add comment about x-key in tests * Fix tests from merging against Devin's changes * Appease linter --------- Co-authored-by: Danilo Joksimovic <[email protected]> Co-authored-by: Danilo Joksimovic <[email protected]>
djoksimo
added a commit
that referenced
this pull request
Jun 17, 2024
* [FX-1376] Fetch rosetta-traffic-percentage to determine vault provider (#258) * add support for reading rosetta-traffic-percentage flag to LDManager * update LDManager.getVaultProvider tests * re-organize and combine lines * remove `vault-primary-traffic-percentage` flag references entirely * update LDManager tests * add TODO comment to clean up vgsVaultWrapper * clean up unused imports * [FX-1368] Re-introduce the ForageVaultWrapper (#260) * add ForageResponseParser * add ForagePinSubmitter * add ForageVaultWrapper * use ForageVaultWrapper in ForagePINEditText * flip logic around to reduce unnecessary diff * update comment * Update forage-android/src/main/java/com/joinforage/forage/android/ecom/ui/ForagePINEditText.kt Co-authored-by: Danilo Joksimovic <[email protected]> * Rotate sample app value for customer-id Force re-tokenization of test cards in mobile-qa-tets * [FX-1451] Add unit tests for RosettaPinSubmitter and RosettaPinElement (#261) * Add unit tests for ForagePinSubmitter * Add RosettaPinElement tests! * Add test for checking default text size * Bring parity to corner styles * Add comment about x-key in tests * Fix tests from merging against Devin's changes * Appease linter --------- Co-authored-by: Danilo Joksimovic <[email protected]> Co-authored-by: Danilo Joksimovic <[email protected]> --------- Co-authored-by: Danilo Joksimovic <[email protected]> Co-authored-by: Danilo Joksimovic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
RosettaPinSubmitterForageVaultWrapperUI element--
Test Plan
How
Can be released as-is, should be included before 6/20