[FX-1376] Fetch rosetta-traffic-percentage to determine vault provider #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djoksimo
requested changes
May 29, 2024
| internal fun computeVaultType(trafficPrimaryPercentFlag: Double): VaultType { | ||
| val randomNum = Math.random() * 100 | ||
| return if (randomNum < trafficPrimaryPercentFlag) VaultType.BT_VAULT_TYPE else VaultType.VGS_VAULT_TYPE | ||
| } | ||
|
|
||
| internal fun shouldUseRosetta(rosettaPercentFlag: Double): Boolean { | ||
| val randomNum = Math.random() * 100 | ||
| return randomNum < rosettaPercentFlag |
There was a problem hiding this comment.
nit: should be randomNum <= rosettaPercentFlag to favor rosetta in the unlikely case that randomNum = 100
Comment on lines
34
to
37
| internal fun computeVaultType(trafficPrimaryPercentFlag: Double): VaultType { | ||
| val randomNum = Math.random() * 100 | ||
| return if (randomNum < trafficPrimaryPercentFlag) VaultType.BT_VAULT_TYPE else VaultType.VGS_VAULT_TYPE | ||
| } |
There was a problem hiding this comment.
can drop vault-primary-traffic-percentage entirely in favor of rosetta-traffic-percentage, as discussed in slack
evanfreeze
requested review from
owenkim,
ForageRob,
dleis612 and
devinmorgan
as code owners
dleis612
approved these changes
May 30, 2024
djoksimo
approved these changes
May 30, 2024
evanfreeze
changed the base branch from
main
to
evan/remove-vault-percentage-flag
evanfreeze
merged commit 963cbf1
into
evan/remove-vault-percentage-flag
6 checks passed
djoksimo
deleted the
evan/fx-1376-fetch-rosetta-traffic-percentage-to-determine-whether-to
branch
djoksimo
pushed a commit
that referenced
this pull request
Jun 17, 2024
#258) * add support for reading rosetta-traffic-percentage flag to LDManager * update LDManager.getVaultProvider tests * re-organize and combine lines * remove `vault-primary-traffic-percentage` flag references entirely * update LDManager tests * add TODO comment to clean up vgsVaultWrapper * clean up unused imports
djoksimo
added a commit
that referenced
this pull request
Jun 17, 2024
* [FX-1376] Fetch rosetta-traffic-percentage to determine vault provider (#258) * add support for reading rosetta-traffic-percentage flag to LDManager * update LDManager.getVaultProvider tests * re-organize and combine lines * remove `vault-primary-traffic-percentage` flag references entirely * update LDManager tests * add TODO comment to clean up vgsVaultWrapper * clean up unused imports * [FX-1368] Re-introduce the ForageVaultWrapper (#260) * add ForageResponseParser * add ForagePinSubmitter * add ForageVaultWrapper * use ForageVaultWrapper in ForagePINEditText * flip logic around to reduce unnecessary diff * update comment * Update forage-android/src/main/java/com/joinforage/forage/android/ecom/ui/ForagePINEditText.kt Co-authored-by: Danilo Joksimovic <[email protected]> * Rotate sample app value for customer-id Force re-tokenization of test cards in mobile-qa-tets * [FX-1451] Add unit tests for RosettaPinSubmitter and RosettaPinElement (#261) * Add unit tests for ForagePinSubmitter * Add RosettaPinElement tests! * Add test for checking default text size * Bring parity to corner styles * Add comment about x-key in tests * Fix tests from merging against Devin's changes * Appease linter --------- Co-authored-by: Danilo Joksimovic <[email protected]> Co-authored-by: Danilo Joksimovic <[email protected]> --------- Co-authored-by: Danilo Joksimovic <[email protected]> Co-authored-by: Danilo Joksimovic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
rosetta-traffic-percentagein LaunchDarkly to determine vault provider, only checkingvault-primary-traffic-percentageif we aren't using rosetta based on the initial flag check.Why
https://linear.app/joinforage/issue/FX-1376/fetch-rosetta-traffic-percentage-to-determine-whether-to-route-between
Test Plan
How
Can be merged as-is, as far as I know?