Organize all files into core and ecom packages #247
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @devinmorgan and the rest of your teammates on |
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @devinmorgan and the rest of your teammates on |
devinmorgan
force-pushed
the
devin/fx-1322-organize-public-ecom-repo-into-ecom-and-core-packages
branch
from
219ce40 to
dff9a5f
Compare
devinmorgan
force-pushed
the
devin/move-things-to-core-and-ecom
branch
from
a9c23d4 to
6458699
Compare
devinmorgan
force-pushed
the
devin/fx-1322-organize-public-ecom-repo-into-ecom-and-core-packages
branch
from
dff9a5f to
be479a9
Compare
devinmorgan
force-pushed
the
devin/move-things-to-core-and-ecom
branch
from
6458699 to
1772e21
Compare
devinmorgan
requested review from
owenkim,
ForageRob,
dleis612,
djoksimo and
evanfreeze
as code owners
devinmorgan
commented
May 10, 2024
Comment on lines
+83
to
+106
| // This extension splits the path by "/" and adds each segment individually to the path. | ||
| // This is to prevent the URL from getting corrupted through internal OKHttp URL encoding. | ||
| internal fun HttpUrl.Builder.addPathSegmentsSafe(path: String): HttpUrl.Builder { | ||
| path.split("/").forEach { segment -> | ||
| if (segment.isNotEmpty()) { | ||
| this.addPathSegment(segment) | ||
| } | ||
| } | ||
| return this | ||
| } | ||
|
|
||
| /** | ||
| * [JSONObject.optString] has trouble falling back to `null` and seems to fallback to `"null"` (string) instead | ||
| */ | ||
| internal fun JSONObject.getStringOrNull(fieldName: String): String? { | ||
| if (!has(fieldName) || isNull(fieldName)) { | ||
| return null | ||
| } | ||
| return optString(fieldName) | ||
| } | ||
|
|
||
| internal fun JSONObject.hasNonNull(fieldName: String): Boolean { | ||
| return has(fieldName) && !isNull(fieldName) | ||
| } |
There was a problem hiding this comment.
Moved forage.android.Utils.kt to forage.android.core.services.Utils.kt
The second step in the public ecommerce repo that needs to take place in order to make sharing code between the private pos repo and this repo pain free; all while allowing for both repos to evolve independently Signed-off-by: Devin Morgan <[email protected]>
devinmorgan
force-pushed
the
devin/fx-1322-organize-public-ecom-repo-into-ecom-and-core-packages
branch
from
be479a9 to
0bb7834
Compare
devinmorgan
force-pushed
the
devin/move-things-to-core-and-ecom
branch
from
1772e21 to
ee43184
Compare
|
As discussed in the rollout planning, I merged #248 directly into |
This was referenced Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Step 2 of Part 1.
Why
See here
Test Plan
Demo
N/A - no new functionality
How
This PR will not get merged into
main.I am leaving it open to make it easier for folks to review the code changes in the whole stack. I will end up pointing #248 tomainand merging that in. I will close this PR and #246 once folks have approved the stack. See here for more detail.