[TW-573] Document Android POS SDK example responses #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimberleehowley
added
the
documentation
kimberleehowley
requested review from
owenkim,
ForageRob,
dleis612,
devinmorgan,
djoksimo and
evanfreeze
as code owners
djoksimo
requested changes
Apr 9, 2024
djoksimo
approved these changes
Apr 12, 2024
There was a problem hiding this comment.
Thank you incorporating this change @kimberleehowley! I know Github links are not ideal, as you said, but we'll come up with a better workaround soon!
| * On failure, the response includes a list of | ||
| * [ForageError][com.joinforage.forage.android.network.model.ForageError] objects that you can | ||
| * unpack to troubleshoot the issue. | ||
| * PIN capture. |
There was a problem hiding this comment.
nit: This was present before, but can we change (in this/future PR) all instances of PIN capture to say "secure PIN submission" or something alike
Given that capture is used in the context of "payment capture"
kimberleehowley
deleted the
kimberlee/tw-573-document-android-sdk-example-responses
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR adds the example success schemas to the relevant POS SDK methods.
Note that I debated including a concrete response instead of the schema, but ultimately I decided to go with the industry standard pattern of the schema. Please Slack me with any questions!
Why
This could spare customers the trouble of digging in the codebase for the schema.
Test Plan