[FX-1128] Remove get merchants call from pos cert app #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanfreeze
requested review from
owenkim,
ForageRob,
dleis612,
devinmorgan and
djoksimo
as code owners
djoksimo
requested changes
Mar 1, 2024
djoksimo
approved these changes
Mar 1, 2024
evanfreeze
deleted the
evan/fx-1128-remove-get-merchants-call-from-pos-app
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Removes the call to get merchant details from the POS cert app and updates the UI to use a hard-coded test merchant for the merchant name and address. Merchant ID will still read from whatever is provided in the text field in Merchant Setup.
Why
https://linear.app/joinforage/issue/FX-1128/remove-get-merchants-call-from-pos-app
Test Plan
How
Can be merged as-is