[FX-780] Fix isValid initial value for PIN bug
#136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinmorgan
requested review from
owenkim,
ForageRob,
dleis612 and
djoksimo
as code owners
This was referenced Dec 4, 2023
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
devinmorgan
changed the title
isValid initial value for PIN bug
dleis612
approved these changes
Dec 4, 2023
djoksimo
approved these changes
Dec 4, 2023
devinmorgan
force-pushed
the
devin/update-sample-app-to-show-usState
branch
from
bd5d961 to
a179c0a
Compare
devinmorgan
force-pushed
the
devin/fx-780-fix-isvalid-default-state-in-android-sdk
branch
2 times, most recently
from
0e07df2 to
8ec1919
Compare
devinmorgan
force-pushed
the
devin/update-sample-app-to-show-usState
branch
from
853dce9 to
299b305
Compare
devinmorgan
force-pushed
the
devin/fx-780-fix-isvalid-default-state-in-android-sdk
branch
from
93df9d1 to
bb43754
Compare
devinmorgan
changed the base branch from
devin/update-sample-app-to-show-usState
to
main
devinmorgan
force-pushed
the
devin/fx-780-fix-isvalid-default-state-in-android-sdk
branch
from
bb43754 to
8ed83f1
Compare
devinmorgan
deleted the
devin/fx-780-fix-isvalid-default-state-in-android-sdk
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Borrowing Danny's #135 and including it in this Graphite stack for convenience. In addition, added two unit tests to run automated assertions against
INITIAL_PIN_ELEMENT_STATEandINTIAL_PIN_ELEMENT_STATEso that fiddling with these constants in an undesirable way would make noiseWhy
See the linear ticket
Test Plan
How
This PR should be released after #133 get's merged in because it leverages the new variables
INITIAL_PIN_ELEMENT_STATEandINTIAL_PIN_ELEMENT_STATE, which are introduced in #133