Skip to content

Commit

Permalink
fix: skiplibcheck for the preview
Browse files Browse the repository at this point in the history
  • Loading branch information
ocombe committed Dec 7, 2023
1 parent 4b9134b commit d5c2fa5
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 11 deletions.
8 changes: 3 additions & 5 deletions angular/devkit/compiler/ng-packagr/ng-packagr.compiler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,10 @@ import { CyclicError } from '@teambit/graph.cleargraph';
import { IsolatorAspect, IsolatorMain } from '@teambit/isolator';
import { PACKAGE_JSON } from '@teambit/legacy/dist/constants';
import PackageJsonFile from '@teambit/legacy/dist/consumer/component/package-json-file';
import removeFilesAndEmptyDirsRecursively
from '@teambit/legacy/dist/utils/fs/remove-files-and-empty-dirs-recursively';
import { Logger } from '@teambit/logger';
import { Workspace } from '@teambit/workspace';
import chalk from 'chalk';
import { mkdirsSync, outputFileSync } from 'fs-extra';
import { mkdirsSync, outputFileSync, removeSync } from 'fs-extra';
import type { NgPackageConfig } from 'ng-packagr/ng-package.schema';
import { join, posix, resolve } from 'path';
import { Diagnostic, DiagnosticCategory, DiagnosticWithLocation } from 'typescript';
Expand Down Expand Up @@ -239,8 +237,8 @@ export class NgPackagrCompiler implements Compiler {
packageJson.mergePackageJsonObject(jsonProps);
await packageJson.write();
// delete the [ng-]package.json file generated by ngPackagr
await removeFilesAndEmptyDirsRecursively([resolve(join(pathToOutputFolder, this.distDir, PACKAGE_JSON))]);
await removeFilesAndEmptyDirsRecursively([resolve(ngPackageJsonPath)]);
removeSync(resolve(join(pathToOutputFolder, this.distDir, PACKAGE_JSON)));
removeSync(resolve(ngPackageJsonPath));
// eslint-disable-next-line consistent-return
}, async(err: Error) => {
if (err.message === ViewEngineTemplateError && !tsCompilerOptions.fullTemplateTypeCheck) {
Expand Down
7 changes: 1 addition & 6 deletions angular/devkit/preview/preview/preview-app/tsconfig.app.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,6 @@
"allowJs": true,
"allowSyntheticDefaultImports": true,
"baseUrl": "./",
"outDir": "./dist/out-tsc/app",
"forceConsistentCasingInFileNames": true,
"strict": true,
"noImplicitReturns": true,
"noFallthroughCasesInSwitch": true,
"sourceMap": true,
"declaration": false,
"downlevelIteration": true,
"experimentalDecorators": true,
Expand All @@ -27,6 +21,7 @@
"noImplicitReturns": true,
"outDir": "./dist/out-tsc/app",
"preserveSymlinks": false,
"skipLibCheck": true,
"sourceMap": true,
"strict": true,
"target": "es5"
Expand Down

0 comments on commit d5c2fa5

Please sign in to comment.