♻️ :: Test코드 추가

team-xquare · May 24, 2023 · e79f76c · e79f76c
1 parent 214544a
commit e79f76c
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 34 deletions.
diff --git a/...domain/src/main/kotlin/io/github/v1servicenotification/stubs/InMemorySettingRepository.kt b/...domain/src/main/kotlin/io/github/v1servicenotification/stubs/InMemorySettingRepository.kt
@@ -24,9 +24,7 @@ class InMemorySettingRepository(
     }
 
     override fun settingExist(categoryIds: List<UUID>, userId: UUID): Boolean {
-        return categoryIds.mapNotNull {
-            findSetting(userId, it)
-        }.isNotEmpty()
+        return categoryIds.map { findSetting(userId, it) }.any { it != null }
     }
 
     override fun queryActivatedCategory(userId: UUID): List<Category> {

diff --git a/...cation-domain/src/test/kotlin/io/github/v1servicenotification/detail/DetailApiImplTest.kt b/...cation-domain/src/test/kotlin/io/github/v1servicenotification/detail/DetailApiImplTest.kt
@@ -67,9 +67,11 @@ class DetailApiImplTest {
             topic = "ALL"
         )
 
+        val categoryIds = listOf(category.id)
+
         categorySpi.saveCategory(category)
 
-        settingSpi.saveAllSetting(category, userId, true)
+        settingSpi.updateAllSetting(categoryIds, userId, true)
 
         detailSpi.save(category)
 
@@ -102,9 +104,11 @@ class DetailApiImplTest {
             topic = "ALL"
         )
 
+        val categoryIds = listOf(category.id)
+
         categorySpi.saveCategory(category)
 
-        settingSpi.saveAllSetting(category, userId, false)
+        settingSpi.updateAllSetting(categoryIds, userId, false)
 
         detailSpi.save(category)
 
@@ -135,9 +139,11 @@ class DetailApiImplTest {
             topic = "ALL"
         )
 
+        val categoryIds = listOf(category.id)
+
         categorySpi.saveCategory(category)
 
-        settingSpi.saveAllSetting(category, userId, false)
+        settingSpi.updateAllSetting(categoryIds, userId, false)
 
         detailSpi.save(category)
 

diff --git a/...tion-domain/src/test/kotlin/io/github/v1servicenotification/setting/SettingApiImplTest.kt b/...tion-domain/src/test/kotlin/io/github/v1servicenotification/setting/SettingApiImplTest.kt
@@ -26,8 +26,11 @@ class SettingApiImplTest {
 
         settingSpi.saveCategory(category)
 
-        settingSpi.saveAllSetting(
-            category,
+        val categoryIds = listOf(category.id)
+
+
+        settingSpi.updateAllSetting(
+            categoryIds,
             userId,
             true
         )
@@ -39,30 +42,4 @@ class SettingApiImplTest {
         assertThat(result.destination).isEqualTo(category.destination)
 
     }
-
-    @Test
-    fun deActivatedCategory() {
-        val userId = UUID.randomUUID()
-        val categoryId = UUID.randomUUID()
-        categorySpi.saveCategory(
-            Category(categoryId, "Test name", "Test destination", false, "ALL")
-        )
-        Assertions.assertThat(settingApi.deActivateCategory(categoryId, userId))
-            .isEqualTo(201)
-        Assertions.assertThat(settingApi.deActivateCategory(categoryId, userId))
-            .isEqualTo(204)
-    }
-
-    @Test
-    fun activateCategory() {
-        val userId = UUID.randomUUID()
-        val categoryId = UUID.randomUUID()
-        categorySpi.saveCategory(
-            Category(categoryId, "Test name", "Test destination", false, "ALL")
-        )
-        assertThat(settingApi.activateOrDeActivateCategory(categoryId, userId))
-            .isEqualTo(201)
-        assertThat(settingApi.activateOrDeActivateCategory(categoryId, userId))
-            .isEqualTo(204)
-    }
 }