♻️ :: 코드리뷰 수정

team-xquare · May 11, 2023 · b38bd65 · b38bd65
1 parent b246ec1
commit b38bd65
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/notification-domain/src/main/kotlin/io/github/v1servicenotification/error/ErrorCode.kt b/notification-domain/src/main/kotlin/io/github/v1servicenotification/error/ErrorCode.kt
@@ -22,5 +22,5 @@ enum class ErrorCode(
 
     INTERNAL_SERVER_ERROR(500, "GLOBAL-500-1", "Internal Server Error."),
 
-    DEVICE_TOKEN_LENGTH(400, "DEVICE-400-1", "Device Token Length Error.");
+    DEVICE_TOKEN_LENGTH(400, "DEVICE-400-1", "Device Token Length Error.")
 }
diff --git a/...in/kotlin/io/github/v1servicenotification/error/NotificationDeviceTokenLengthException.kt b/...in/kotlin/io/github/v1servicenotification/error/NotificationDeviceTokenLengthException.kt
@@ -1,6 +1,6 @@
 package io.github.v1servicenotification.error
 
-class NotificationDeviceTokenLengthException private constructor(): NotificationException(ErrorCode.DETAIL_NOT_FOUND) {
+class NotificationDeviceTokenLengthException private constructor(): NotificationException(ErrorCode.DEVICE_TOKEN_LENGTH) {
 
     companion object {
         @JvmField

diff --git a/...n-infrastructure/src/main/kotlin/io/github/v1servicenotification/global/fcm/FcmService.kt b/...n-infrastructure/src/main/kotlin/io/github/v1servicenotification/global/fcm/FcmService.kt
@@ -8,14 +8,17 @@ import com.google.firebase.messaging.MulticastMessage
 import com.google.firebase.messaging.Notification
 import io.github.v1servicenotification.detail.spi.PostDetailFcmSpi
 import io.github.v1servicenotification.error.NotificationDeviceTokenLengthException
-import io.github.v1servicenotification.error.NotificationException
 import org.springframework.stereotype.Service
 
 @Service
 class FcmService: PostDetailFcmSpi {
 
+    companion object {
+        const val MAX_TOKEN_LENGTH = 163
+    }
+
     override fun sendGroupMessage(tokenList: List<String>, title: String, content: String, threadId: String) {
-        val validTokens = tokenList.filter { it.length == 163 }
+        val validTokens = tokenList.filter { it.length == MAX_TOKEN_LENGTH }
         if (validTokens.isNotEmpty()) {
             val multicast = MulticastMessage.builder()
                 .addAllTokens(validTokens)
@@ -41,7 +44,7 @@ class FcmService: PostDetailFcmSpi {
     }
 
     override fun sendMessage(token: String, title: String, content: String, threadId: String) {
-        if (token.length >= 163) {
+        if (token.length >= MAX_TOKEN_LENGTH) {
             val message = Message.builder()
                 .setToken(token)
                 .setNotification(