Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase against on Element X develop #17

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

yostyle
Copy link

@yostyle yostyle commented Nov 25, 2024

Content

Motivation and context

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

ganfra and others added 10 commits November 22, 2024 17:13
…plication can detect if the call has been answered on another session.

This is dealing with the case the application is not in foreground.
…entCall

Ensure that the SDK is syncing during an incoming call so that the app can cancel the notification
…onents-sdk-android-0.x

Update dependency org.matrix.rustcomponents:sdk-android to v0.2.65
…t_before_enabling

change : confirm biometric before allowing biometric unlock.
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@yostyle yostyle self-assigned this Nov 25, 2024
Copy link

Thank you for your contribution! Here are a few things to check in the PR to ensure it's reviewed as quickly as possible:

  • Your branch should be based on origin/develop, at least when it was created.
  • The title of the PR will be used for release notes, so it needs to describe the change visible to the user.
  • The test pass locally running ./gradlew test.
  • The code quality check suite pass locally running ./gradlew runQualityChecks.
  • If you modified anything related to the UI, including previews, you'll have to run the Record screenshots GH action in your forked repo: that will generate compatible new screenshots. However, given Github Actions limitations, it will prevent the CI from running temporarily, until you upload a new commit after that one. To do so, just pull the latest changes and push an empty commit.

@yostyle yostyle added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants