Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: GlobalObject cannot be undefined in the GetGlobalObject #3445

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Editorial: GlobalObject cannot be undefined in the GetGlobalObject #3445

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fade924
Add assertion for GetGlobalObject must not be undefined
kimjg1119 Oct 2, 2024
4e71641
Merge branch 'main' into get-global-object
kimjg1119 Nov 21, 2024
966db9a
Remove undefined form GlobalObject
kimjg1119 Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions spec.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11721,7 +11721,7 @@ <h1>Realms</h1>
[[GlobalObject]]
</td>
<td>
an Object or *undefined*
an Object
</td>
<td>
The global object for this realm
Expand Down Expand Up @@ -11787,7 +11787,6 @@ <h1>InitializeHostDefinedRealm ( ): either a normal completion containing ~unuse
1. Perform CreateIntrinsics(_realm_).
1. Set _realm_.[[AgentSignifier]] to AgentSignifier().
1. Set _realm_.[[GlobalObject]] to *undefined*.
1. Set _realm_.[[GlobalEnv]] to *undefined*.
1. Set _realm_.[[TemplateMap]] to a new empty List.
1. Let _newContext_ be a new execution context.
1. Set the Function of _newContext_ to *null*.
Expand Down Expand Up @@ -12054,6 +12053,7 @@ <h1>GetGlobalObject ( ): an Object</h1>
</dl>
<emu-alg>
1. Let _currentRealm_ be the current Realm Record.
1. Assert: _currentRealm_.[[GlobalObject]] is not *undefined*.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This assertion is no longer necessary.

1. Return _currentRealm_.[[GlobalObject]].
</emu-alg>
</emu-clause>
Expand Down
Loading