Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nan_typedarraycontents.h: API has changed #15

Open
rgobbel opened this issue Dec 12, 2022 · 1 comment
Open

nan_typedarraycontents.h: API has changed #15

rgobbel opened this issue Dec 12, 2022 · 1 comment

Comments

@rgobbel
Copy link

rgobbel commented Dec 12, 2022

Node's API for ArrayBuffers has changed, as described in https://docs.google.com/document/d/1sTc_jRL87Fu175Holm5SV0kajkseGl2r8ifGY76G35k

In nan_typedarraycontents.h, this change (at line 34) makes it compile:

//      data   = static_cast<char*>(buffer->GetContents().Data()) + byte_offset;
      std::shared_ptr<v8::BackingStore> backing = buffer->GetBackingStore();
      data   = static_cast<char*>(backing->Data()) + byte_offset;
@JHenzi
Copy link

JHenzi commented Mar 18, 2023

This seems to have the module install entirely broken, the npm i command doesn't execute any longer because of an exception inside of electron-rebuild:

An unhandled error occurred inside electron-rebuild
Could not detect abi for version 22.3.2 and runtime electron.  Updating "node-abi" might help solve this issue if it is a new release of electron

Error: Could not detect abi for version 22.3.2 and runtime electron.  Updating "node-abi" might help solve this issue if it is a new release of electron
    at Object.getAbi (/home/pi/MagicMirror/modules/MMM-FlightTracker/node_modules/magicmirror-rebuild/node_modules/node-abi/index.js:39:9)
    at new Rebuilder (/home/pi/MagicMirror/modules/MMM-FlightTracker/node_modules/magicmirror-rebuild/build/rebuild.js:100:48)
    at rebuildWithOptions (/home/pi/MagicMirror/modules/MMM-FlightTracker/node_modules/magicmirror-rebuild/build/rebuild.js:249:23)
    at doRebuild (/home/pi/MagicMirror/modules/MMM-FlightTracker/node_modules/magicmirror-rebuild/build/rebuild.js:272:16)
    at /home/pi/MagicMirror/modules/MMM-FlightTracker/node_modules/magicmirror-rebuild/build/cli.js:115:45
npm ERR! code 255
npm ERR! path /home/pi/MagicMirror/modules/MMM-FlightTracker
npm ERR! command failed
npm ERR! command sh -c -- ./node_modules/.bin/MagicMirror-rebuild

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/pi/.npm/_logs/2023-03-18T06_23_20_343Z-debug-0.log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants