Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update header.html #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update header.html #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions layouts/partials/header.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,32 +27,32 @@ <h4>{{ .Site.Params.description }}</h4>
{{ $icon_size := "64px" }}
{{ if .Site.Params.email }}
<a href="mailto:{{ .Site.Params.email }}" title="Email">
<img alt="Email" height="{{ $icon_size }}" width="{{ $icon_size }}" src="{{ "/images/email.svg" | relURL}}" />
<img alt="Email" height="{{ $icon_size }}" width="{{ $icon_size }}" src="{{ "/images/icons/email.svg" | relURL}}" />
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of being more organized with the static assets. If you move the corresponding files from ./static/images in this repo

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. Actually I did that at later stage because as you mentioned being organized is a good. Thanks.

</a>
{{ end }}
{{ if .Site.Params.github }}
<a href="https://github.com/{{ .Site.Params.github }}" title="Github">
<img alt="GitHub" height="{{ $icon_size }}" width="{{ $icon_size }}" src="{{ "/images/github.svg" | relURL}}" />
<img alt="GitHub" height="{{ $icon_size }}" width="{{ $icon_size }}" src="{{ "/images/icons/github.svg" | relURL}}" />
</a>
{{ end }}
{{ if .Site.Params.facebook }}
<a href="https://facebook.com/{{ .Site.Params.facebook }}" title="Facebook">
<img alt="Facebook" height="{{ $icon_size }}" width="{{ $icon_size }}" src="{{"/images/facebook.svg" | relURL}}" />
<img alt="Facebook" height="{{ $icon_size }}" width="{{ $icon_size }}" src="{{"/images/icons/facebook.svg" | relURL}}" />
</a>
{{ end }}
{{ if .Site.Params.twitter }}
<a href="https://twitter.com/{{ .Site.Params.twitter }}" title="Twitter">
<img alt="Twitter" height="{{ $icon_size }}" width="{{ $icon_size }}" src="{{"/images/twitter.svg" | relURL}}" />
<img alt="Twitter" height="{{ $icon_size }}" width="{{ $icon_size }}" src="{{"/images/icons/twitter.svg" | relURL}}" />
</a>
{{ end }}
{{ if .Site.Params.linkedin }}
<a href="https://linkedin.com/in/{{ .Site.Params.linkedin }}" title="LinkedIn">
<img alt="LinkedIn" height="{{ $icon_size }}" width="{{ $icon_size }}" src="{{"/images/linkedin.svg" | relURL}}" />
<img alt="LinkedIn" height="{{ $icon_size }}" width="{{ $icon_size }}" src="{{"/images/icons/linkedin.svg" | relURL}}" />
</a>
{{ end }}
{{ if .Site.Params.youtube }}
<a href="https://youtube.com/user/{{ .Site.Params.youtube }}" title="Youtube">
<img alt="Youtube" height="{{ $icon_size }}" width="{{ $icon_size }}" src="{{"/images/youtube.svg" | relURL}}" />
<img alt="Youtube" height="{{ $icon_size }}" width="{{ $icon_size }}" src="{{"/images/icons/youtube.svg" | relURL}}" />
</a>
{{ end }}
</div>
Expand Down