~2x speedup using numba decorator in one single place #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks a lot for this pure python port of potrace!
Looking at cProfile results, I saw that
findnext()
is a performance hotspot. By introducing numba, and adding a singlenumba.njit()
decorator tofindnext
, a 2x speedup is achieved. I am sure there is a lot more possible, this is just the lowest of the low hanging fruits.I did not touch the default installation and only added numba as an optional dependency. Users with the need for more performance can install using
pip install potracer[numba]
. I updated the Readme.md accordingly.Profiling results:
I used this image to test: link, and was able to reduce the runtime from ~60 seconds to ~26 seconds.
Before:
After adding @numba.njit() to findnext():