ngmin replaced by ngAnnotate. Ticket #16

tapas4java · Nov 9, 2014 · 97db317 · 97db317
1 parent f314862
commit 97db317
Show file tree

Hide file tree

Showing 12 changed files with 24 additions and 25 deletions.
diff --git a/app/templates/skeleton/Gruntfile.js b/app/templates/skeleton/Gruntfile.js
@@ -139,7 +139,7 @@ module.exports = function (grunt) {
         dest: 'temp/app.full.js'
       }
     },
-    ngmin: {
+    ngAnnotate: {
       main: {
         src:'temp/app.full.js',
         dest: 'temp/app.full.js'
@@ -207,7 +207,7 @@ module.exports = function (grunt) {
 
   });
 
-  grunt.registerTask('build', ['jshint', 'clean:before', 'less', 'dom_munger', 'ngtemplates', 'cssmin', 'concat', 'ngmin', 'uglify', 'copy', 'htmlmin', 'imagemin', 'clean:after']);
+  grunt.registerTask('build', ['jshint', 'clean:before', 'less', 'dom_munger', 'ngtemplates', 'cssmin', 'concat', 'ngAnnotate', 'uglify', 'copy', 'htmlmin', 'imagemin', 'clean:after']);
   grunt.registerTask('run', ['dom_munger:read', 'jshint', 'connect', 'watch']);
   grunt.registerTask('test', ['dom_munger:read', 'karma']);
   grunt.registerTask('e2e', ['dom_munger:read', 'protractor']);

diff --git a/app/templates/skeleton/app/common/controllers/common-controller.js b/app/templates/skeleton/app/common/controllers/common-controller.js
@@ -8,11 +8,10 @@
      * @author: Tapas Jena
      * @copyright: Anitech Consulting Services Pvt Ltd.
      */
-    angular.module('common').controller('commonController', ['$scope', function($scope) {
+    angular.module('common').controller('commonController', function($scope) {
 
         //TODO: Implement your controller logic here
 
-    }]);
-
+    });
 
 })();
diff --git a/app/templates/skeleton/app/common/services/common-service.js b/app/templates/skeleton/app/common/services/common-service.js
@@ -8,11 +8,10 @@
      * @author: Tapas Jena
      * @copyright: Anitech Consulting Services Pvt Ltd.
      */
-    angular.module('common').service('commonService', ['$http', '$q', function($http, $q) {
+    angular.module('common').service('commonService', function($http, $q) {
 
         //TODO: Implement your service logic here
 
-    }]);
-
+    });
 
 })();
diff --git a/app/templates/skeleton/app/help/controllers/help-controller.js b/app/templates/skeleton/app/help/controllers/help-controller.js
@@ -8,10 +8,10 @@
      * @author: Tapas Jena
      * @copyright: Anitech Consulting Services Pvt Ltd.
      */
-    angular.module('help').controller('helpController', ['$scope', 'loadContent', function($scope, loadContent) {
+    angular.module('help').controller('helpController', function($scope, loadContent) {
 
         $scope.helpContentList = loadContent;
 
-    }]);
+    });
 
 })();
diff --git a/app/templates/skeleton/app/help/services/help-service.js b/app/templates/skeleton/app/help/services/help-service.js
@@ -8,7 +8,7 @@
      * @author: Tapas Jena
      * @copyright: Anitech Consulting Services Pvt Ltd.
      */
-    angular.module('help').service('helpService', ['$http', '$q', function($http, $q) {
+    angular.module('help').service('helpService', function($http, $q) {
 
         var helpContent = [];
 
@@ -27,6 +27,6 @@
             return deferred.promise;
         };
 
-    }]);
+    });
 
 })();
diff --git a/app/templates/skeleton/app/home/controllers/home-controller.js b/app/templates/skeleton/app/home/controllers/home-controller.js
@@ -8,11 +8,11 @@
      * @author: Tapas Jena
      * @copyright: Anitech Consulting Services Pvt Ltd.
      */
-    angular.module('home').controller('homeController', ['$scope', 'homeService', function($scope, homeService) {
+    angular.module('home').controller('homeController', function($scope, homeService) {
 
         // get message from service
         $scope.message = homeService.getMessage();
 
-    }]);
+    });
 
 })();
diff --git a/app/templates/skeleton/app/home/services/home-service.js b/app/templates/skeleton/app/home/services/home-service.js
@@ -8,7 +8,7 @@
      * @author: Tapas Jena
      * @copyright: Anitech Consulting Services Pvt Ltd.
      */
-    angular.module('home').service('homeService', ['$http', '$q', function($http, $q) {
+    angular.module('home').service('homeService', function($http, $q) {
 
         var message = '';
 
@@ -20,6 +20,6 @@
             return message;
         };
 
-    }]);
+    });
 
 })();
diff --git a/app/templates/skeleton/app/index.html b/app/templates/skeleton/app/index.html
@@ -1,5 +1,5 @@
 <!DOCTYPE html>
-<html ng-app="<%= _.camelize(appname) %>">
+<html ng-app="<%= _.camelize(appname) %>" >
 <head>
   <title>ng-AppGen - Angular Application Generator</title>
   <meta name="viewport" content="width=device-width, initial-scale=1.0">

diff --git a/app/templates/skeleton/package.json b/app/templates/skeleton/package.json
@@ -3,13 +3,13 @@
     "version": "0.0.1",
     "repository": {
         "type": "git",
-        "url": "https://github.com/<%= _.slugify(appname).git"
+        "url": "https://github.com"
     },
     "devDependencies": {
         "grunt": "~0.4.5",
         "grunt-dom-munger": "~3.4",
         "grunt-angular-templates": "~0.5.7",
-        "grunt-ngmin": "0.0.3",
+        "grunt-ng-annotate": "0.5.0",
         "grunt-contrib-connect": "~0.9.0",
         "grunt-contrib-copy": "~0.7.0",
         "grunt-contrib-clean": "~0.6.0",
@@ -34,4 +34,5 @@
         "webdriver-manager": "1.0.0",
         "grunt-protractor-runner": "1.1.4"
     }
+
 }
diff --git a/controller/templates/controller.js b/controller/templates/controller.js
@@ -8,10 +8,10 @@
      * @author: Tapas Jena
      * @copyright: Anitech Consulting Services Pvt Ltd.
      */
-    angular.module('<%= appname %>').controller('<%= _.camelize(name) %>', ['$scope', function($scope) {
+    angular.module('<%= appname %>').controller('<%= _.camelize(name) %>', function($scope) {
 
         //TODO: Implement your controller logic here
 
-    }]);
+    });
 
 })();
diff --git a/filter/templates/filter.js b/filter/templates/filter.js
@@ -8,13 +8,13 @@
      * @author: Tapas Jena
      * @copyright: Anitech Consulting Services Pvt Ltd.
      */
-    angular.module('<%= appname %>').filter('<%= _.camelize(name) %>', ['$scope', function($scope) {
+    angular.module('<%= appname %>').filter('<%= _.camelize(name) %>', function($scope) {
 
         //TODO: Implement your filter logic here
         return function(input,arg) {
             return 'output';
         };
 
-    }]);
+    });
 
 })();
diff --git a/service/templates/service.js b/service/templates/service.js
@@ -8,10 +8,10 @@
      * @author: Tapas Jena
      * @copyright: Anitech Consulting Services Pvt Ltd.
      */
-    angular.module('<%= appname %>').service('<%= _.camelize(name) %>', ['$http', '$q', function($http, $q) {
+    angular.module('<%= appname %>').service('<%= _.camelize(name) %>', function($http, $q) {
 
         //TODO: Implement your service logic here
 
-    }]);
+    });
 
 })();