Propose bitbang modes in the builder pattern. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, I haven't commented this PR yet. Yes, it is controversial, and I need to think through it to understand the consequences. |
I'm happy to live up to your expectations :P.
N.b. I'm not attached to this PR. It was pushed as a draft to start discussing a type safe way to separate the various modes an FTDI chip can be in. Feel free to make an alternate PR if you want so we can discuss. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okay, this PR I concede it's probably controversial, but I at least wanted to get a draft out the door before I stop working for the night :D.
bitbang::BitBangrepresents asynchronous bitbang. The carefully-namedBitBangtrait should be implemented for e.g.Mpsseas well.A user can go straight into asynchronous bitbang mode from
Builder::new().usb_open()?.bitbang(...)?. For MPSSE,Builder::new().usb_open()?.mpsse(...)?etc.