Update Leaderboard Submission Dialog to Pass Parameters to ViewModel

This commit updates the Leaderboard Submission Dialog to pass the team name, repository URL, and commit SHA as parameters to the submitToLeaderboard function in the SkillTreeViewModel. These changes ensure that the dialog and the ViewModel are aligned in terms of parameter requirements, facilitating efficient and accurate leaderboard submissions.
tannerchiang · Sep 27, 2023 · 105b801 · 105b801
1 parent ec03170
commit 105b801
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/frontend/lib/views/task_queue/leaderboard_submission_dialog.dart b/frontend/lib/views/task_queue/leaderboard_submission_dialog.dart
@@ -4,7 +4,7 @@ import 'package:flutter/material.dart';
 import 'package:shared_preferences/shared_preferences.dart';
 
 class LeaderboardSubmissionDialog extends StatefulWidget {
-  final VoidCallback? onSubmit;
+  final Function(String, String, String)? onSubmit;
 
   const LeaderboardSubmissionDialog({
     Key? key,
@@ -73,7 +73,8 @@ class _LeaderboardSubmissionDialogState
 
     if (isValid) {
       _saveToSharedPreferences();
-      widget.onSubmit?.call();
+      widget.onSubmit?.call(_teamNameController.text, _repoUrlController.text,
+          _commitShaController.text);
     } else {
       setState(() {});
     }

diff --git a/frontend/lib/views/task_queue/task_queue_view.dart b/frontend/lib/views/task_queue/task_queue_view.dart
@@ -121,7 +121,10 @@ class TaskQueueView extends StatelessWidget {
                           showDialog(
                             context: context,
                             builder: (context) => LeaderboardSubmissionDialog(
-                              onSubmit: viewModel.submitToLeaderboard,
+                              onSubmit: (teamName, repoUrl, commitSha) {
+                                viewModel.submitToLeaderboard(
+                                    teamName, repoUrl, commitSha);
+                              },
                             ),
                           );
                         },