-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
- Add translation (en/fr) #4
base: devel
Are you sure you want to change the base?
Conversation
erodataM
commented
Nov 19, 2014
- Add Google Analytics like menu
- Add Google Analytics like menu
Hello Lionel, we are pleased to see you taking an interest in this daterangepicker implementation and we thank you for the contribution. However, having studied your use case and the implementation, it seems that the current widget is rather limited. For example, what happens if someone else wants 3 ranges, or they want 2 ranges with a different menu than your current one? It occurred to us that we should first open the daterangepicker a little bit more and allow third parties to implement custom plugins without affecting the base widget. This way we would allow for any number of menu implementations, any number of data formats and any number of ranges. Having done that, it would be easier to build variations of the widget and at the same time have better control over the core code. We will leave the issue open for now so that others that require a GA menu can refer to your implementation. Once we make the above mentioned refactoring to our code we will let you know. Unfortunately we can't give a timeline/deadline on this. |
Thank you for answer. |
Hello erodataM, if you want a french version of the datarangepicker, no need to re-write the code.
|